You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/02/22 16:01:21 UTC

[GitHub] flink pull request #3357: [FLINK-5827] [table] Exception when do filter afte...

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3357#discussion_r102497060
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala ---
    @@ -188,7 +189,12 @@ trait CommonCorrelate {
             |getCollector().collect(${crossResultExpr.resultTerm});
             |""".stripMargin
         } else {
    -      val filterGenerator = new CodeGenerator(config, false, udtfTypeInfo)
    +      val filterGenerator =
    +        udtfTypeInfo match {
    +          case pt: PojoTypeInfo[_] => new CodeGenerator(config, false, udtfTypeInfo, None,
    --- End diff --
    
    I think we don't need a pattern matching here. `pojoFieldMapping` is option anyway so we can pass it directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---