You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Erick Erickson <er...@gmail.com> on 2012/02/14 15:07:57 UTC
new Admin UI and license information
While I was working on some of the LukeRequestHandler speedups, I
noticed that there were no license notifications in the new Admin UI
code, so I stuck some in and committed it (r: 1243925). Two questions:
1> Is there any need for a JIRA here?
2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
already had a license notification in them. I added in the Apache
license information, should I have?
Thanks,
Erick
P.S. I did a very quick triage to see that that I didn't use, say, the
wrong comment form, but it was *very* quick. If functionality has
disappeared mysteriously, here's where I'd look first.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
I didn't even know about rat; funny how the same things get reinvented
over and over again:
https://github.com/carrot2/carrot2/tree/master/lib/org.carrot2.antlib/src/main/java/org/carrot2/antlib/tasks
Dawid
On Tue, Feb 14, 2012 at 7:15 PM, Robert Muir <rc...@gmail.com> wrote:
> We also have 'ant rat-sources' which works from within any module (yes
> Dawid, this one actually would be better top-level!)
>
> for it to work, just put apache-rat-0.8.jar in your ~/.ant/lib
>
> On Tue, Feb 14, 2012 at 12:58 PM, Erick Erickson
> <er...@gmail.com> wrote:
>> Hmmm, I just happened to notice this, I'm not really a license cop...
>>
>> But what the heck. Off the top of my head,
>> html, js, jsp, vm and tpl are extensions that may make sense to look at.
>>
>> Erick
>>
>> On Tue, Feb 14, 2012 at 10:19 AM, Dawid Weiss
>> <da...@cs.put.poznan.pl> wrote:
>>> By the way -- that license-check macro can work with any files, not
>>> only with *.jar files. It's basically a mapping from a fileset
>>> resources to other resource names. I can help in adding validation for
>>> *.js or whatever so that they are checked for licenses too.
>>>
>>> Dawid
>>>
>>> On Tue, Feb 14, 2012 at 3:07 PM, Erick Erickson <er...@gmail.com> wrote:
>>>> While I was working on some of the LukeRequestHandler speedups, I
>>>> noticed that there were no license notifications in the new Admin UI
>>>> code, so I stuck some in and committed it (r: 1243925). Two questions:
>>>>
>>>> 1> Is there any need for a JIRA here?
>>>> 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
>>>> already had a license notification in them. I added in the Apache
>>>> license information, should I have?
>>>>
>>>> Thanks,
>>>> Erick
>>>>
>>>> P.S. I did a very quick triage to see that that I didn't use, say, the
>>>> wrong comment form, but it was *very* quick. If functionality has
>>>> disappeared mysteriously, here's where I'd look first.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
>
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Robert Muir <rc...@gmail.com>.
We also have 'ant rat-sources' which works from within any module (yes
Dawid, this one actually would be better top-level!)
for it to work, just put apache-rat-0.8.jar in your ~/.ant/lib
On Tue, Feb 14, 2012 at 12:58 PM, Erick Erickson
<er...@gmail.com> wrote:
> Hmmm, I just happened to notice this, I'm not really a license cop...
>
> But what the heck. Off the top of my head,
> html, js, jsp, vm and tpl are extensions that may make sense to look at.
>
> Erick
>
> On Tue, Feb 14, 2012 at 10:19 AM, Dawid Weiss
> <da...@cs.put.poznan.pl> wrote:
>> By the way -- that license-check macro can work with any files, not
>> only with *.jar files. It's basically a mapping from a fileset
>> resources to other resource names. I can help in adding validation for
>> *.js or whatever so that they are checked for licenses too.
>>
>> Dawid
>>
>> On Tue, Feb 14, 2012 at 3:07 PM, Erick Erickson <er...@gmail.com> wrote:
>>> While I was working on some of the LukeRequestHandler speedups, I
>>> noticed that there were no license notifications in the new Admin UI
>>> code, so I stuck some in and committed it (r: 1243925). Two questions:
>>>
>>> 1> Is there any need for a JIRA here?
>>> 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
>>> already had a license notification in them. I added in the Apache
>>> license information, should I have?
>>>
>>> Thanks,
>>> Erick
>>>
>>> P.S. I did a very quick triage to see that that I didn't use, say, the
>>> wrong comment form, but it was *very* quick. If functionality has
>>> disappeared mysteriously, here's where I'd look first.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Erick Erickson <er...@gmail.com>.
Hmmm, I just happened to notice this, I'm not really a license cop...
But what the heck. Off the top of my head,
html, js, jsp, vm and tpl are extensions that may make sense to look at.
Erick
On Tue, Feb 14, 2012 at 10:19 AM, Dawid Weiss
<da...@cs.put.poznan.pl> wrote:
> By the way -- that license-check macro can work with any files, not
> only with *.jar files. It's basically a mapping from a fileset
> resources to other resource names. I can help in adding validation for
> *.js or whatever so that they are checked for licenses too.
>
> Dawid
>
> On Tue, Feb 14, 2012 at 3:07 PM, Erick Erickson <er...@gmail.com> wrote:
>> While I was working on some of the LukeRequestHandler speedups, I
>> noticed that there were no license notifications in the new Admin UI
>> code, so I stuck some in and committed it (r: 1243925). Two questions:
>>
>> 1> Is there any need for a JIRA here?
>> 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
>> already had a license notification in them. I added in the Apache
>> license information, should I have?
>>
>> Thanks,
>> Erick
>>
>> P.S. I did a very quick triage to see that that I didn't use, say, the
>> wrong comment form, but it was *very* quick. If functionality has
>> disappeared mysteriously, here's where I'd look first.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
By the way -- that license-check macro can work with any files, not
only with *.jar files. It's basically a mapping from a fileset
resources to other resource names. I can help in adding validation for
*.js or whatever so that they are checked for licenses too.
Dawid
On Tue, Feb 14, 2012 at 3:07 PM, Erick Erickson <er...@gmail.com> wrote:
> While I was working on some of the LukeRequestHandler speedups, I
> noticed that there were no license notifications in the new Admin UI
> code, so I stuck some in and committed it (r: 1243925). Two questions:
>
> 1> Is there any need for a JIRA here?
> 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
> already had a license notification in them. I added in the Apache
> license information, should I have?
>
> Thanks,
> Erick
>
> P.S. I did a very quick triage to see that that I didn't use, say, the
> wrong comment form, but it was *very* quick. If functionality has
> disappeared mysteriously, here's where I'd look first.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Erick Erickson <er...@gmail.com>.
Right, that makes sense, we have no authority to re-license anything.
I removed them.
Thanks,
Erick
On Wed, Feb 15, 2012 at 3:59 PM, Chris Hostetter
<ho...@fucit.org> wrote:
>
> : 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
> : already had a license notification in them. I added in the Apache
> : license information, should I have?
>
> IANAL but I'm pretty sure you should *not* replace/add an ASL header to
> any file that already has some other license header -- particularly since
> i'm pretty sure jquery sparklines is under the BSD license, not ASL.
>
> This would be like removing a LICENSE.txt file from inside a jar that
> says it's under the MIT license, with copyright info about who created it, and
> replacing it with a LICENSE.txt file that says it' distributed under the
> ASL license.
>
> pretty sure that's not kosher.
>
>
> -Hoss
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: new Admin UI and license information
Posted by Chris Hostetter <ho...@fucit.org>.
: 2> ...solr/webapp/web/js/jquery.sparkline.js and a couple of others
: already had a license notification in them. I added in the Apache
: license information, should I have?
IANAL but I'm pretty sure you should *not* replace/add an ASL header to
any file that already has some other license header -- particularly since
i'm pretty sure jquery sparklines is under the BSD license, not ASL.
This would be like removing a LICENSE.txt file from inside a jar that
says it's under the MIT license, with copyright info about who created it, and
replacing it with a LICENSE.txt file that says it' distributed under the
ASL license.
pretty sure that's not kosher.
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org