[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r286247200
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/timeline/DataSegmentWithOvershadowedStatus.java
 ##########
 @@ -25,16 +25,16 @@
 /**
  * DataSegment object plus the overshadowed status for the segment. An immutable object.
  *
- * SegmentWithOvershadowedStatus's {@link #compareTo} method considers only the {@link SegmentId}
+ * DataSegmentWithOvershadowedStatus's {@link #compareTo} method considers only the {@link SegmentId}
  * of the DataSegment object.
  */
-public class SegmentWithOvershadowedStatus implements Comparable<SegmentWithOvershadowedStatus>
+public class DataSegmentWithOvershadowedStatus implements Comparable<DataSegmentWithOvershadowedStatus>
 
 Review comment:
   I would undo the rename, I don't think it's really necessary here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org