You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by markncooper <gi...@git.apache.org> on 2016/02/18 21:14:22 UTC
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
GitHub user markncooper opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/725
Added CSV and Tableau export functionality
** What is this PR for?
Allow users to export data in a paragraph to a CSV and / or Tableau via Tableau's WDC feature
** What type of PR is it?
Feature
** TODOs
This feature is partially incomplete - I want to drop the limit on only exporting 1000 (or however many) rows are shown in the UI. For our purpose we hacked backend support for this to our custom interpreter but I am looking for recommendations on the "proper" way to do this.
** Is there a relevant Jira issue?
Sort of - ZEPPELIN-672 is the most similar
**How should this be tested?
create a paragraph with data in %table view
select the "Export to CSV" or "Export to Tableau WDC" item in the paragraph settings list
** Does the licenses files need update?
NO
** Is there breaking changes for older versions?
NO
** Does this needs documentation?
Possibly. Here's a screenshot of it in action.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brigade/incubator-zeppelin exporterFeature
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #725
----
commit eaf207591750da188262eea21b895ac76504136b
Author: Mark Cooper <ma...@brigade.com>
Date: 2016-02-05T06:49:14Z
Added CSV and Tableau export functionality
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by markncooper <gi...@git.apache.org>.
Github user markncooper commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-185918386
The big issue with simply exporting from the frontend is that you can only export as many rows as are displayed by the UI, right? I'd like to dump 1000s of rows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-217896651
@jmrr Yes, The goal was to take care of the export using #714 and #725 (for front and back-end export).
This would allow most of the PR to be merged, and a good thing about it is that the feature is not connected directly to the table plugin we want to use. #858 for example is proposing a new table.
#761 was merged without a change in title indeed (so it can be misleading).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-198150918
@markncooper Thanks for the contribution.
If you're trying to drop limit of number of rows to be downloaded, how about following approach?
[Make an abstraction of any result data](https://issues.apache.org/jira/browse/ZEPPELIN-753) and share it to the ResourcePool. And then it can be used in rest end point to be downloaded. This approach was discussed in https://github.com/apache/incubator-zeppelin/pull/413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #725: Added CSV and Tableau export functionality
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/725
@jmrr Good Question.
Front-end Download has been merged, now we could also add some backend one for full data download.
@markncooper any feedbacks regarding @Leemoonsoo comments above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-185983438
@markncooper @zhongneu Hello folks, this issue is handled by #6 initially. I think it's better that we focus one PR only. Do you mind improving #6 by comment or some implementations? In case of same issue with many PR, I think we should respect the first one. How about you guys?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by zhongneu <gi...@git.apache.org>.
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-185906306
@markncooper I am working on a pull request for this: https://github.com/apache/incubator-zeppelin/pull/714
I think we can directly export the data in frontend
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by zhongneu <gi...@git.apache.org>.
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-185934584
@markncooper Right, but if the export button is in the chart interface, shouldn't we only export the rows shown in UI?
I also have a very similar case of exporting the "full report" than only the data UI shows. I am trying to work on some walk-around: create a dynamic form (or angular) for exporting the full reports, and register the exporting action on the dynamic form.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export func...
Posted by jmrr <gi...@git.apache.org>.
Github user jmrr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-217839838
I'm a bit confused. @corneadoug said in #761 that this PR, #725, will handle the export via a REST call through the `Settings` button. However @jongyoul mentions that #6 will take care of this capability but @zhongneu is working on #714. At the same time #761 has been merged with a misleading title and reduction of features. I understand we haven't come up with the best approach but the issue would benefit from some consensus, as the approach of having multiple overlapping PRs on the same topic has hampered the development of the feature. I haven't started any of these PRs but I offer myself to test them and benchmark them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Added CSV and Tableau export functionality
Posted by jmrr <gi...@git.apache.org>.
Github user jmrr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725
So how are we on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---