[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4996: [relay][external codegen] outline and inline lifted functions for external codegen

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #4996: [relay][external codegen] outline and inline lifted functions for external codegen
URL: https://github.com/apache/incubator-tvm/pull/4996#discussion_r389051897
 
 

 ##########
 File path: src/relay/backend/vm/inline_primitives.cc
 ##########
 @@ -122,6 +122,7 @@ struct PrimitiveInliner : ExprMutator {
       auto global = pair.first;
       auto base_func = pair.second;
       if (auto* n = base_func.as<FunctionNode>()) {
+        if (!n->UseDefaultCompiler()) continue;
 
 Review comment:
   We probably cannot do that. All functions in prelude are global functions. Also lamb lifting will lift some closures to the global scope. These functions should be treated as normal ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services