You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/04/02 02:12:44 UTC

[GitHub] [incubator-shenyu] AhahaGe commented on a change in pull request #3172: [ISSUE #3171] change threadPool to CachedThreadPool from ForkJoinPool

AhahaGe commented on a change in pull request #3172:
URL: https://github.com/apache/incubator-shenyu/pull/3172#discussion_r840993891



##########
File path: shenyu-plugin/shenyu-plugin-motan/src/main/java/org/apache/shenyu/plugin/motan/proxy/MotanProxyService.java
##########
@@ -46,6 +49,8 @@
 
     private static final Logger LOG = LoggerFactory.getLogger(MotanProxyService.class);
 
+    private final ExecutorService threadPool = Executors.newCachedThreadPool(ShenyuThreadFactory.create("shenyu-motan", true));

Review comment:
       for your mail, when we have a large number of requests, cached thread pool may create Integer.MAX_VALUE size threads, may cause oom




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org