You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/23 09:13:26 UTC

[GitHub] [dolphinscheduler] BenjaminWenqiYu opened a new pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

BenjaminWenqiYu opened a new pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315


   when I delete the processDefinition, it's related task will also be deleted
   
   Purpose of the pull request
   when I delete the processDefinition, it's related task will also be deleted
   
   Brief change log
   when I delete the processDefinition, It will delete the processTaskRelation and the related task.
   
   Verify this pull request
   This pull request is code cleanup without any test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] BenjaminWenqiYu closed pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
BenjaminWenqiYu closed pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#issuecomment-927818875


   This is not bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] BenjaminWenqiYu closed pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
BenjaminWenqiYu closed pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] BenjaminWenqiYu commented on pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
BenjaminWenqiYu commented on pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#issuecomment-928660189






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] BenjaminWenqiYu commented on pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
BenjaminWenqiYu commented on pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#issuecomment-928660189


   thanks you, I will delete the issue and pr later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] lenboo commented on pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
lenboo commented on pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#issuecomment-925659423


   @BenjaminWenqiYu  
   Thank you very much for your contribution.
   Is there any issues related to this pr ?
   You can find some details here:
   https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on a change in pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#discussion_r714797354



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -648,9 +648,14 @@ public Result queryProcessDefinitionListPaging(User loginUser, long projectCode,
             }
         }
 
-        int delete = processDefinitionMapper.deleteById(processDefinition.getId());
+        int deleteProcessDefinition = processDefinitionMapper.deleteById(processDefinition.getId());
+        List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(project.getCode(), processDefinition.getCode());
+        int deleteRelatedTask = 1;
+        for (ProcessTaskRelation processTaskRelation : processTaskRelations) {
+            deleteRelatedTask &= taskDefinitionMapper.deleteByCode(processTaskRelation.getPostTaskCode());

Review comment:
       Thanks for your contribution. It can't be modified here. The initial design is that tasks are organized through workflows. Tasks and workflows are parallel. Subsequent workflows will support task references and have an interface to operate tasks separately




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] BenjaminWenqiYu commented on pull request #6315: [#6314][Bug][API] when I delete the processDefinition, it's related task will also be deleted

Posted by GitBox <gi...@apache.org>.
BenjaminWenqiYu commented on pull request #6315:
URL: https://github.com/apache/dolphinscheduler/pull/6315#issuecomment-928663186


   the task and workflow are parallel, it's not a bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org