You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/01 23:09:42 UTC

[GitHub] [tvm] mei-ye opened a new issue #10135: [Bug]

mei-ye opened a new issue #10135:
URL: https://github.com/apache/tvm/issues/10135


   On windows, the max stack size is 1 MB, whereas it is 8 MB on Linux.   So stack overflow occurs more often on windows for large graphs.   We run into a stack overflow problem on windows.  The cause is recursive function calls in relay/transforms/device_planner.cc.   A fix is posted in: https://github.com/apache/tvm/pull/10124
   
   From the code review feedback, the best approach is to rewrite the pass using MixedModeVisitor. 
   
   Attached test_pass_plan_devices.py, where test_stack_overflow can be used to expose this bug.  In test_stack_overflow, a loop is used to generate a big graph.  You can adjust the loop count until stack overflow occurs.  I can help to test the fix on windows.
   
   [test_pass_plan_devices.zip](https://github.com/apache/tvm/files/7982505/test_pass_plan_devices.zip)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 closed issue #10135: [Bug] Update DevicePlanner to use MixedModeVisitor

Posted by GitBox <gi...@apache.org>.

tmoreau89 closed issue #10135:
URL: https://github.com/apache/tvm/issues/10135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 closed issue #10135: [Bug] Update DevicePlanner to use MixedModeVisitor

Posted by GitBox <gi...@apache.org>.

tmoreau89 closed issue #10135:
URL: https://github.com/apache/tvm/issues/10135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org