You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Hongten (via GitHub)" <gi...@apache.org> on 2023/02/10 03:21:14 UTC

[GitHub] [pulsar] Hongten commented on a diff in pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

Hongten commented on code in PR #10201:
URL: https://github.com/apache/pulsar/pull/10201#discussion_r1102236103


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceUsageTransportManager.java:
##########
@@ -172,12 +186,26 @@ private void createTenantAndNamespace() throws PulsarServerException, PulsarAdmi
 
         List<String> tenantList =  admin.tenants().getTenants();
         if (!tenantList.contains(tenant)) {
-            admin.tenants().createTenant(tenant,
-                    new TenantInfo(Sets.newHashSet(config.getSuperUserRoles()), Sets.newHashSet(cluster)));
+            try {

Review Comment:
   To add try/catch is a good solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org