[jira] [Commented] (KAFKA-458) remove errorcode from ByteBufferMessageSet

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447786#comment-13447786 ] 

Jun Rao commented on KAFKA-458:
-------------------------------

Thanks for patch v2. Some comments:

1. ByteBufferMessageSet: To be consistent btw the java and the scala version, we should have a public api serialized() to get the serialized byteBuffer and make buffer a private field. Also, the javaapi version needs to define hashCode since it may be used in a map.

2. ByteBufferMessageSet, KafkaETLContext: remove unused imports.




                
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
>                 Key: KAFKA-458
>                 URL: https://issues.apache.org/jira/browse/KAFKA-458
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>              Labels: optimization
>             Fix For: 0.8
>
>         Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira