[GitHub] [flink] zentol commented on a diff in pull request #19363: [FLINK-27059][tests][JUnit5 migration] flink-compress

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19363:
URL: https://github.com/apache/flink/pull/19363#discussion_r842660896


##########
flink-formats/flink-compress/src/test/java/org/apache/flink/formats/compress/CompressionFactoryITCase.java:
##########
@@ -43,27 +43,24 @@
 import java.util.List;
 import java.util.stream.Collectors;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 /**
  * Integration test case for writing bulk encoded files with the {@link StreamingFileSink} and
  * Hadoop Compression Codecs.
  */
-public class CompressionFactoryITCase extends AbstractTestBase {
+class CompressionFactoryITCase extends AbstractTestBase {

Review Comment:
   This seems fishy given that it extends AbstractTestBase which is still on junit4.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org