[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #2133: ci: optimize build rpm workflow with apisix-build-tools v2.2.0

[GitBox <gi...@apache.org>]

imjoey commented on a change in pull request #2133:
URL: https://github.com/apache/apisix-dashboard/pull/2133#discussion_r705869721



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,16 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+
+      - uses: actions/cache@v2
+        with:
+          path: /tmp/.buildx-cache
+          key: ${{ runner.os }}-buildx-apisixdashboard-${{ github.sha }}
+          restore-keys: |
+            ${{ runner.os }}-buildx-apisixdashboard-
+            ${{ runner.os }}-buildx-

Review comment:
       @starsz currently the apisix-build-tools only cache the fpm image for building, which may be considered as consistent. So I guess that's way @qsliu2017 use `restore-keys` here. While I must admit that, if there're other tasks for building images here, it definitely would cause stale cache problems.
   
   @qsliu2017 What do you think? Please let us know your explanations. Thanks.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org