You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "M4n5ter (via GitHub)" <gi...@apache.org> on 2026/09/14 14:08:53 UTC
[PR] fix(ui): expand model wheels in place without empty ends [maka]
M4n5ter opened a new pull request, #5305:
URL: https://github.com/apache/maka/pull/5305
<details open>
<summary>English</summary>
## Summary
The shared model selector now expands in place into the original floating-composer wheel. The button disappears while the wheel is open; composer controls and settings rows retain their layout. The wheel has a slightly translucent background, keeps the selected label enlarged, and applies a settled selection without a confirmation click.
The first and last models are adjacent in a circular list, so neither end has an empty row. Keyboard arrows follow the same order. Compact floating WorkHub uses the wheel's actual inline height, replacing the separate space previously reserved above the composer. Near a viewport edge, the wheel shifts only enough to remain visible.
Follow-up to #5257, based on `ea990cab7` from main.
## Verification
- UI and Desktop renderer builds, Desktop typechecks, Storybook build/typecheck, and changed-file Biome checks passed.
- 3 picker/recovery component tests and 50 relevant Storybook renders passed, including light/dark and narrow WorkHub, settings, daily review, subagents and provider configuration.
- Additional Chromium checks passed for two-option scrolling at both physical limits and reverse Tab. Mutations restoring detached positioning or removing the circular neighbors failed the new browser assertions.
- Full local Electron E2E: **38/38 passed**, without retries. The native WorkHub test checks window containment, bottom anchoring and dragging the wheel without dragging the frameless window. E2E budget remains 38 tests in 22 files; no fixture launches were added or removed.
- The full repository unit suite and complete Storybook catalog were not run. CI is not being awaited.
Actual screenshots follow. The compact composer is captured from Electron; other views use production components in Storybook.
Compact floating composer:
Docked composer, closed and expanded (the surrounding layout stays fixed):
Settings row:
Narrow floating progress card, light and dark:
First and last catalog models, with real neighboring options at both edges:
## Pending visual agreement
- [ ] Confirm in-place expansion, overlap and translucency from the screenshots.
- [ ] Confirm the circular first/last behavior and compact floating composer appearance.
- [ ] Mark ready for review only after agreement.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the picker changes, performed correctness and simplification reviews, updated regression coverage, ran validation and captured screenshots.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
</details>
<details>
<summary>中文</summary>
## Summary / 变更说明
所有模型选择入口改为原来悬浮 composer 的滚轮效果：展开时按钮原位变成滚轮，普通输入区和设置页保留原来的布局，滚轮覆盖在上面。背景略微透明，当前模型的文字保持局部放大，滚动吸附后直接选中，不用再点一次确认。
模型首尾循环衔接，前后都能看到真实选项，不再留空行；键盘上下键也按同样的顺序切换。WorkHub 紧凑悬浮窗按滚轮实际占位调整高度，移除了之前在输入区上方额外预留的空白。靠近窗口边缘时，滚轮会小幅挪动，确保完整显示。
这是 #5257 的后续调整，基于 main 的 `ea990cab7`。
## Verification / 验证
- UI、Desktop renderer 和 Storybook 构建、Desktop 类型检查，以及修改文件的 lint、格式检查通过。
- 3 个选择器/恢复流程组件测试、50 个相关浏览器场景通过，覆盖明暗主题、窄窗、设置页、每日回顾、子 Agent 和供应商配置。
- 两项模型滚到上下极限、反向 Tab 均已验证；人为恢复旁边弹出的定位，或去掉首尾相邻项，新断言都会失败。
- 本地完整 Electron E2E：**38/38 通过**，无重试。原生测试验证悬浮窗不裁切滚轮、保持底部定位，以及拖动滚轮不会带着无边框窗口走。仍为 22 个文件、38 个测试，没有增减原生测试的启动次数。
- 未运行全仓库单元测试和完整 Storybook 目录；不等待 CI。
英文部分附有 8 张实际截图：原生悬浮 composer、普通输入框展开前后、设置页、进度卡片明暗主题，以及首项和末项。除原生悬浮窗外，其余截图来自 Storybook 中的生产组件，没有改图。
## Pending visual agreement / 待确认
- [ ] 确认原位展开、覆盖范围和透明度符合预期。
- [ ] 确认首尾循环及悬浮 composer 的效果。
- [ ] 双方对齐后再转为 ready for review。
## AI use / AI 使用
- [ ] 未使用生成式工具进行实质性工作
- [x] 使用了生成式工具进行实质性工作
工具及范围：Codex 完成实现、正确性与简化审查、回归验证和实际截图。
## Checklist / 检查项
- [x] 测试覆盖改动，恢复问题后会失败
- [x] lint、格式、类型检查及相关测试在本地通过
本 PR 是否改变行为？
- [x] 是，已在变更说明中描述
- [ ] 否
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): expand model wheels in place without empty ends [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #5305:
URL: https://github.com/apache/maka/pull/5305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org