You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/04 18:03:30 UTC

Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64032/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 6:03 p.m.)


Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.


Bugs: MESOS-8297
    https://issues.apache.org/jira/browse/MESOS-8297


Repository: mesos


Description
-------

When the executor library receives messages while being disconnected,
it might indicate an out-of-order message delivery or lost messages.
This should be logged at the warning level to simplify triaging.


Diffs
-----

  src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc 


Diff: https://reviews.apache.org/r/64032/diff/2/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov


Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64032/#review193542
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Budnik


On Dec. 4, 2017, 6:03 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64032/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
> 
> 
> Bugs: MESOS-8297
>     https://issues.apache.org/jira/browse/MESOS-8297
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the executor library receives messages while being disconnected,
> it might indicate an out-of-order message delivery or lost messages.
> This should be logged at the warning level to simplify triaging.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc 
> 
> 
> Diff: https://reviews.apache.org/r/64032/diff/2/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64032/
-----------------------------------------------------------

(Updated Dec. 20, 2017, 8:14 p.m.)


Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.


Bugs: MESOS-8297
    https://issues.apache.org/jira/browse/MESOS-8297


Repository: mesos


Description
-------

When the executor library receives messages while being disconnected,
it might indicate an out-of-order message delivery or lost messages.
This should be logged at the warning level to simplify triaging.


Diffs (updated)
-----

  src/exec/exec.cpp 7fc46daa633ca42944123a7546ac4eceea93956d 


Diff: https://reviews.apache.org/r/64032/diff/3/

Changes: https://reviews.apache.org/r/64032/diff/2-3/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov