You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sandor Molnar <sm...@hortonworks.com> on 2017/12/01 08:49:28 UTC
Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
Bugs: AMBARI-22560
https://issues.apache.org/jira/browse/AMBARI-22560
Repository: ambari
Description
-------
Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 455814aa65
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java b774436d28
Diff: https://reviews.apache.org/r/64215/diff/1/
Testing
-------
Tested on vagrant cluster
Thanks,
Sandor Molnar
Re: Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
Posted by Sandor Molnar <sm...@hortonworks.com>.
> On Dec. 1, 2017, 9:03 a.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Line 1454 (original), 1453 (patched)
> > <https://reviews.apache.org/r/64215/diff/1/?file=1904635#file1904635line1454>
> >
> > Do we still need this getCluster() and the null check?
Since we have the same checks in the underlying updateCluster(...) cll this is redundant. Let me submit a new one.
- Sandor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192453
-----------------------------------------------------------
On Dec. 1, 2017, 10:09 a.m., Sandor Molnar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 10:09 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
>
>
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java da206c6ccf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java d1f235f885
>
>
> Diff: https://reviews.apache.org/r/64215/diff/2/
>
>
> Testing
> -------
>
> Tested on vagrant cluster
>
>
> Thanks,
>
> Sandor Molnar
>
>
Re: Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192453
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 1454 (original), 1453 (patched)
<https://reviews.apache.org/r/64215/#comment270605>
Do we still need this getCluster() and the null check?
- Attila Magyar
On Dec. 1, 2017, 8:49 a.m., Sandor Molnar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 8:49 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
>
>
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 455814aa65
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java b774436d28
>
>
> Diff: https://reviews.apache.org/r/64215/diff/1/
>
>
> Testing
> -------
>
> Tested on vagrant cluster
>
>
> Thanks,
>
> Sandor Molnar
>
>
Re: Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192460
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Dec. 1, 2017, 10:09 a.m., Sandor Molnar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 10:09 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
>
>
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java da206c6ccf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java d1f235f885
>
>
> Diff: https://reviews.apache.org/r/64215/diff/2/
>
>
> Testing
> -------
>
> Tested on vagrant cluster
>
>
> Thanks,
>
> Sandor Molnar
>
>
Re: Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192480
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Dec. 1, 2017, 5:09 a.m., Sandor Molnar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 5:09 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
>
>
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java da206c6ccf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java d1f235f885
>
>
> Diff: https://reviews.apache.org/r/64215/diff/2/
>
>
> Testing
> -------
>
> Tested on vagrant cluster
>
>
> Thanks,
>
> Sandor Molnar
>
>
Re: Review Request 64215: Remove obsolete hack to set KDC admin
credentials via Cluster session API
Posted by Sandor Molnar <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 10:09 a.m.)
Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
Bugs: AMBARI-22560
https://issues.apache.org/jira/browse/AMBARI-22560
Repository: ambari
Description
-------
Remove hack to set KDC admin credential via the API to set session attribute via the Cluster resource.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java da206c6ccf
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java d1f235f885
Diff: https://reviews.apache.org/r/64215/diff/2/
Changes: https://reviews.apache.org/r/64215/diff/1-2/
Testing
-------
Tested on vagrant cluster
Thanks,
Sandor Molnar