[GitHub] [arrow-rs] crepererum commented on a diff in pull request #4151: Cleanup reading page index (#4149) (#4090)

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on code in PR #4151:
URL: https://github.com/apache/arrow-rs/pull/4151#discussion_r1180159292


##########
parquet/src/file/page_index/index_reader.rs:
##########
@@ -24,9 +24,21 @@ use crate::file::metadata::ColumnChunkMetaData;
 use crate::file::page_index::index::{Index, NativeIndex};
 use crate::file::reader::ChunkReader;
 use crate::format::{ColumnIndex, OffsetIndex, PageLocation};
-use std::io::{Cursor, Read};
+use std::io::Cursor;
+use std::ops::Range;
 use thrift::protocol::{TCompactInputProtocol, TSerializable};
 
+/// Computes the aggregate range of two optional ranges

Review Comment:
   What's an "aggregate range"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org