You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/15 20:52:19 UTC
[GitHub] [kafka] hachikuji opened a new pull request #11766: MINOR: Remove redundant forwarding integration tests
hachikuji opened a new pull request #11766:
URL: https://github.com/apache/kafka/pull/11766
We have a few integration tests for the forwarding logic which were added prior to kraft being ready for integration testing. Now that we have enabled kraft in integration tests, these tests are redundant and can be removed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11766: MINOR: Remove redundant forwarding integration tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11766:
URL: https://github.com/apache/kafka/pull/11766#discussion_r807305692
##########
File path: core/src/test/scala/unit/kafka/server/MetadataRequestWithForwardingTest.scala
##########
@@ -1,111 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package kafka.server
-
-import kafka.utils.TestUtils
-import org.apache.kafka.common.errors.UnsupportedVersionException
-import org.apache.kafka.common.protocol.Errors
-import org.apache.kafka.common.requests.MetadataRequest
-import org.junit.jupiter.api.Assertions.{assertEquals, assertNull, assertThrows, assertTrue}
-import org.junit.jupiter.api.{BeforeEach, Test, TestInfo}
-
-import scala.collection.Seq
-import scala.jdk.CollectionConverters._
-
-class MetadataRequestWithForwardingTest extends AbstractMetadataRequestTest {
-
- @BeforeEach
- override def setUp(testInfo: TestInfo): Unit = {
- doSetup(testInfo, createOffsetsTopic = false)
- }
-
- override def enableForwarding: Boolean = true
-
- @Test
- def testAutoTopicCreation(): Unit = {
Review comment:
Note that all of these tests were duplicated from `MetadataRequestTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11766: MINOR: Remove redundant forwarding integration tests
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11766:
URL: https://github.com/apache/kafka/pull/11766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11766: MINOR: Remove redundant forwarding integration tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11766:
URL: https://github.com/apache/kafka/pull/11766#issuecomment-1040791539
cc @dengziming Minor follow-up after your patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #11766: MINOR: Remove redundant forwarding integration tests
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #11766:
URL: https://github.com/apache/kafka/pull/11766#issuecomment-1041063803
Thanks for this nice cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org