You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/03 21:44:23 UTC

[GitHub] [kafka] bbejeck opened a new pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

bbejeck opened a new pull request #9554:
URL: https://github.com/apache/kafka/pull/9554


   During the AK website upgrade, changes made to kafka-site weren't migrated back to kafka-docs.
   
   This PR is an attempt at porting the streams changes to kafka/docs
   
   For the most part, the bulk of the changes in the PR are cosmetic.
   
   For testing:
   
   1. I reviewed the PR diffs
   2. Rendered the changes locally
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck commented on pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#issuecomment-721732656


   Merged #9554 into trunk


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck commented on pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#issuecomment-721734486


   cherry-picked to 2.7


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck merged pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9554:
URL: https://github.com/apache/kafka/pull/9554


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck commented on pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#issuecomment-721409238


   Made another pass over all the docs and found some more fixes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck commented on a change in pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck commented on a change in pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#discussion_r517339602



##########
File path: docs/streams/upgrade-guide.html
##########
@@ -135,14 +134,12 @@ <h3><a id="streams_api_changes_260" href="#streams_api_changes_260">Streams API
         tasks to their new owners in the background. Check out <a href="https://cwiki.apache.org/confluence/x/0i4lBg">KIP-441</a>
         for full details, including several new configs for control over this new feature.
     </p>
-
     <p>
         New end-to-end latency metrics have been added. These task-level metrics will be logged at the INFO level and report the min and max end-to-end latency of a record at the beginning/source node(s)
         and end/terminal node(s) of a task. See <a href="https://cwiki.apache.org/confluence/x/gBkRCQ">KIP-613</a> for more information.
     </p>
-
     <p>
-        As of 2.6.0 Kafka Streams deprecates <code>KStream.through()</code> in favor of the new <code>KStream.repartition()</code> operator
+        As of 2.6.0 Kafka Streams deprecates <code>KStream.through()</code> if favor of the new <code>KStream.repartition()</code> operator

Review comment:
       ack




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] bbejeck commented on a change in pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
bbejeck commented on a change in pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#discussion_r517339026



##########
File path: docs/streams/developer-guide/testing.html
##########
@@ -73,67 +71,55 @@ <h2><a class="toc-backref" href="#testing-topologytestdriver" title="Permalink t
                 You can use the test driver to verify that your specified processor topology computes the correct result
                 with the manually piped in data records.
                 The test driver captures the results records and allows to query its embedded state stores.
-            <pre>
-// Processor API
+            <pre class="line-numbers"><code class="language-text">// Processor API
 Topology topology = new Topology();
 topology.addSource("sourceProcessor", "input-topic");
 topology.addProcessor("processor", ..., "sourceProcessor");
-topology.addSink("sinkProcessor", "result-topic", "processor");
+topology.addSink("sinkProcessor", "output-topic", "processor");
 // or
 // using DSL
 StreamsBuilder builder = new StreamsBuilder();
-builder.stream("input-topic").filter(...).to("result-topic");
+builder.stream("input-topic").filter(...).to("output-topic");

Review comment:
       good catch! Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] vvcephei commented on a change in pull request #9554: KAFKA-10679: [Streams] migrate kafka-site updated docs to kafka/docs

Posted by GitBox <gi...@apache.org>.
vvcephei commented on a change in pull request #9554:
URL: https://github.com/apache/kafka/pull/9554#discussion_r517005864



##########
File path: docs/streams/developer-guide/testing.html
##########
@@ -73,67 +71,55 @@ <h2><a class="toc-backref" href="#testing-topologytestdriver" title="Permalink t
                 You can use the test driver to verify that your specified processor topology computes the correct result
                 with the manually piped in data records.
                 The test driver captures the results records and allows to query its embedded state stores.
-            <pre>
-// Processor API
+            <pre class="line-numbers"><code class="language-text">// Processor API
 Topology topology = new Topology();
 topology.addSource("sourceProcessor", "input-topic");
 topology.addProcessor("processor", ..., "sourceProcessor");
-topology.addSink("sinkProcessor", "result-topic", "processor");
+topology.addSink("sinkProcessor", "output-topic", "processor");
 // or
 // using DSL
 StreamsBuilder builder = new StreamsBuilder();
-builder.stream("input-topic").filter(...).to("result-topic");
+builder.stream("input-topic").filter(...).to("output-topic");

Review comment:
       Hmm, is this supposed to match the output topic in L103 below? That one says "result-topic".

##########
File path: docs/streams/upgrade-guide.html
##########
@@ -135,14 +134,12 @@ <h3><a id="streams_api_changes_260" href="#streams_api_changes_260">Streams API
         tasks to their new owners in the background. Check out <a href="https://cwiki.apache.org/confluence/x/0i4lBg">KIP-441</a>
         for full details, including several new configs for control over this new feature.
     </p>
-
     <p>
         New end-to-end latency metrics have been added. These task-level metrics will be logged at the INFO level and report the min and max end-to-end latency of a record at the beginning/source node(s)
         and end/terminal node(s) of a task. See <a href="https://cwiki.apache.org/confluence/x/gBkRCQ">KIP-613</a> for more information.
     </p>
-
     <p>
-        As of 2.6.0 Kafka Streams deprecates <code>KStream.through()</code> in favor of the new <code>KStream.repartition()</code> operator
+        As of 2.6.0 Kafka Streams deprecates <code>KStream.through()</code> if favor of the new <code>KStream.repartition()</code> operator

Review comment:
       Seems like this change is wrong.
   ```suggestion
           As of 2.6.0 Kafka Streams deprecates <code>KStream.through()</code> in favor of the new <code>KStream.repartition()</code> operator
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org