[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script
URL: https://github.com/apache/cloudstack/pull/3197#discussion_r262482057
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java
 ##########
 @@ -81,6 +81,13 @@ public Answer execute(final MigrateCommand command, final CitrixResourceBase cit
                 }
                 citrixResourceBase.migrateVM(conn, dsthost, vm, vmName);
                 vm.setAffinity(conn, dsthost);
+
+                final String result = citrixResourceBase.callHostPlugin(conn, "vmops", "destroy_network_rules_for_vm", "vmName", command.getVmName());
+                if (result == null || result.isEmpty() || !Boolean.parseBoolean(result)) {
 
 Review comment:
   Have you tried using `BooleanUtils`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services