You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/29 07:00:22 UTC
[GitHub] [flink] wuchong commented on a change in pull request #9781:
[FLINK-14098] Support multiple statements for TableEnvironment.
wuchong commented on a change in pull request #9781: [FLINK-14098] Support multiple statements for TableEnvironment.
URL: https://github.com/apache/flink/pull/9781#discussion_r329340695
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/Planner.java
##########
@@ -61,9 +62,10 @@
* <p>The produced Operation trees should already be validated.
*
* @param statement the sql statement to evaluate
+ * @param operationPreConsumer pre consumer for specific operations
* @return parsed queries as trees of relational {@link Operation}s
*/
- List<Operation> parse(String statement);
+ List<Operation> parse(String statement, Consumer<Operation> operationPreConsumer);
Review comment:
Why do we need the `operationPreConsumer`? As discussed in the JIRA, Calcite Parser already support to parse multiple statements. We don't need to do any pre-operation for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services