You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/03 15:35:23 UTC

[GitHub] [flink] mayuehappy commented on a change in pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

mayuehappy commented on a change in pull request #17525:
URL: https://github.com/apache/flink/pull/17525#discussion_r742067773



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -460,22 +461,66 @@ public void testGetKeysAndNamespaces() throws Exception {
                     backend.getPartitionedState(
                             ns1,
                             StringSerializer.INSTANCE,
-                            new ValueStateDescriptor<>(fieldName, IntSerializer.INSTANCE));
+                            new ValueStateDescriptor<>(
+                                    valueStateFieldName, IntSerializer.INSTANCE));
+
+            MapState<Integer, Integer> keyedState2 =

Review comment:
       OK , I noticed that there is a pair of unit tests `#testGetKeys` and `#testMapStateGetKeys` in `StateBackendTestBase`, which is very similar to my situation. I referred to these codes when I modified it before.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org