You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/04/29 01:39:56 UTC
Review Request: Sqoop2: Generic JDBC Connector should have one static
instance of validator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10820/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Created a static generic JDBC connector instance.
This addresses bug SQOOP-1012.
https://issues.apache.org/jira/browse/SQOOP-1012
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 11c10de
Diff: https://reviews.apache.org/r/10820/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: Generic JDBC Connector should have one static
instance of validator
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10820/#review20109
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On April 29, 2013, 12:26 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10820/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 12:26 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Created a static generic JDBC connector instance.
>
>
> This addresses bug SQOOP-1012.
> https://issues.apache.org/jira/browse/SQOOP-1012
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 11c10de
>
> Diff: https://reviews.apache.org/r/10820/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: Generic JDBC Connector should have one static
instance of validator
Posted by rj...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10820/
-----------------------------------------------------------
(Updated April 29, 2013, 12:26 p.m.)
Review request for Sqoop.
Changes
-------
Implemented Jarek comments
Description
-------
Created a static generic JDBC connector instance.
This addresses bug SQOOP-1012.
https://issues.apache.org/jira/browse/SQOOP-1012
Diffs (updated)
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 11c10de
Diff: https://reviews.apache.org/r/10820/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: Generic JDBC Connector should have one static
instance of validator
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10820/#review19831
-----------------------------------------------------------
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
<https://reviews.apache.org/r/10820/#comment40906>
Would you mind also removing this comment?
- Jarek Cecho
On April 28, 2013, 11:39 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10820/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:39 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Created a static generic JDBC connector instance.
>
>
> This addresses bug SQOOP-1012.
> https://issues.apache.org/jira/browse/SQOOP-1012
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 11c10de
>
> Diff: https://reviews.apache.org/r/10820/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>