You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/21 15:47:27 UTC
[GitHub] [doris] 924060929 opened a new pull request, #11095: (fix)(Nereids) fix ssb and add regression test case
924060929 opened a new pull request, #11095:
URL: https://github.com/apache/doris/pull/11095
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11095: (fix)(Nereids) fix ssb and add regression test case
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11095:
URL: https://github.com/apache/doris/pull/11095#discussion_r928073995
##########
regression-test/suites/ssb_sf1/nereids/q1.1.groovy:
##########
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("ssb_sf1_q1_1_nereids") {
+ sql 'use regression_test_ssb_sf1'
+
+ sql 'set enable_nereids_planner=true'
+ // nereids need vectorized
+ sql 'set enable_vectorized_engine=true'
+
+ sql 'set exec_mem_limit=2147483648*2'
+
+ test {
+ sql """
+ SELECT SUM(lo_extendedprice*lo_discount) AS
Review Comment:
reuse the origin sql and output file conflict the order config, we can add the order config until the origin ssb test change to compare with the ordered result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11095: (fix)(Nereids) fix ssb and add regression test case
Posted by GitBox <gi...@apache.org>.
924060929 merged PR #11095:
URL: https://github.com/apache/doris/pull/11095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #11095: (fix)(Nereids) fix ssb and add regression test case
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #11095:
URL: https://github.com/apache/doris/pull/11095#discussion_r927322394
##########
regression-test/suites/ssb_sf1/nereids/q1.1.groovy:
##########
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("ssb_sf1_q1_1_nereids") {
+ sql 'use regression_test_ssb_sf1'
+
+ sql 'set enable_nereids_planner=true'
+ // nereids need vectorized
+ sql 'set enable_vectorized_engine=true'
+
+ sql 'set exec_mem_limit=2147483648*2'
+
+ test {
+ sql """
+ SELECT SUM(lo_extendedprice*lo_discount) AS
Review Comment:
without 'order by' clause, the regression may fails only because of order. Aggregation algorithms in BE may be changed. .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11095: (fix)(Nereids) fix ssb and add regression test case
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11095:
URL: https://github.com/apache/doris/pull/11095#issuecomment-1191708726
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11095: (fix)(Nereids) fix ssb and add regression test case
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11095:
URL: https://github.com/apache/doris/pull/11095#issuecomment-1193058648
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org