You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/01/17 15:25:21 UTC
[GitHub] [buildstream] doraskayo opened a new pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
doraskayo opened a new pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567
This PR fixes the following issue detected by `gnulib`:
```
...
checking for fchownat... yes
checking whether fchownat works with AT_SYMLINK_NOFOLLOW... no
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1014853656
Is this not a problem for chmod?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] doraskayo commented on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
doraskayo commented on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1015774132
@nanonyme, @juergbi, you're most likely correct regarding `chmod`, but it's most likely not an issue in reality because the `AT_SYMLINK_NOFOLLOW` flag is not currently respected at the kernel side either (see [fchmodat(2)](https://linux.die.net/man/2/fchmodat)). It may become an issue if it's ever implemented at the kernel level, however.
I didn't have time to confirm and test it, so I considered it out of scope for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] juergbi commented on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
juergbi commented on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1014860636
> Is this not a problem for chmod?
I indeed expect the same logic to be needed for `chmod` and `chown`.
Actually, as I understand it, the low level (kernel) FUSE operations are all inode-based (to the extent possible) and libfuse maps inodes to paths to make it easier to implement (certain types of) filesystems. I.e., I would expect that we should never follow symlinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1015818011
Okay, then this sounds good to merge. It would be nice to have actual test suite that would fail if the FUSE implementation is noncompliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1015818011
Okay, then this sounds good to merge. It would be nice to have actual test suite that would fail if the FUSE implementation is noncompliant for future purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] doraskayo edited a comment on pull request #1567: fuse/hardlinks: Do not follow symlinks for chown
Posted by GitBox <gi...@apache.org>.
doraskayo edited a comment on pull request #1567:
URL: https://github.com/apache/buildstream/pull/1567#issuecomment-1015774132
@nanonyme, @juergbi, you're most likely correct regarding `chmod`, but I think it's not an issue in reality because the `AT_SYMLINK_NOFOLLOW` flag is not currently respected at the kernel side either (see [fchmodat(2)](https://linux.die.net/man/2/fchmodat)). It may become an issue if it's ever implemented in the kernel, however.
I mostly didn't have time to confirm and test it, so I considered it out of scope for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org