You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/07/17 07:51:33 UTC

[PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

rickyma opened a new pull request, #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919

   ### What changes were proposed in this pull request?
   
   Set Netty as the default server type.
   
   ### Why are the changes needed?
   
   For: https://github.com/apache/incubator-uniffle/issues/1651.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919#issuecomment-2232725589

   MR/TEZ don't support Netty now. I hesitate to make it default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2747021320

   It seems the MR integretion tests for netty part has failed after setting Netty as the default server type.
   
   Could you please help to fix this? I'm not familiar with MR's part. 
   Something more might need to be done in this https://github.com/apache/uniffle/pull/2016.
   @qijiale76 @zhengchenyu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919#issuecomment-2445738700

   @maobaolong I think you can continue working on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma closed pull request #1919: [#1651] improvement(netty): Set Netty as the default server type
URL: https://github.com/apache/uniffle/pull/1919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma closed pull request #1919: [#1651] improvement(netty): Set Netty as the default server type
URL: https://github.com/apache/uniffle/pull/1919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2746803091

   Merged. Thanks for your reviews @jerqi @zhengchenyu @zuston 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919#issuecomment-2232733199

   ## Test Results
    2 657 files  ±0   2 657 suites  ±0   5h 32m 37s :stopwatch: -55s
      946 tests ±0     940 :white_check_mark:  -  4   1 :zzz: ±0   5 :x: + 4 
   11 799 runs  ±0  11 762 :white_check_mark:  - 21  15 :zzz: ±0  22 :x: +21 
   
   For more details on these failures, see [this check](https://github.com/apache/incubator-uniffle/runs/27550497845).
   
   Results for commit d8512aa0. ± Comparison against base commit f984efb0.
   
   [test-results]:data:application/gzip;base64,H4sIAIiAl2YC/03MTQ7CIBAF4Ks0rF0w6EDHy5gRaELsj6GwMt5daFrs8n3z5n3EEEa/inunNJpLJ9Yc0jm7HDmFZS4CRBuVe6oNuukjPdZs7UbyT6/wrl8NBg5jAWzgY1xikfoT81w3AQzRHo/RYlo121fxgH1VtcZ51S7TFFIJwvUIilmC1wP4XkrG/urIPo0BB0xKGUS+ovj+AFtOI/ETAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919#issuecomment-2232738165

   OK, I'll keep this PR here. When it is ready, anyone can modify on top of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2746726044

   > > MR/TEZ don't support Netty now. I hesitate to make it default.
   > 
   > @jerqi I think maybe we can merge this now? I've fixed the conflicts btw.
   
   Yes, I think we can merge this. cc @maobaolong @zhengchenyu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2746732358

   > > > MR/TEZ don't support Netty now. I hesitate to make it default.
   > > 
   > > 
   > > @jerqi I think maybe we can merge this now? I've fixed the conflicts btw.
   > 
   > Yes, I think we can merge this. cc @maobaolong @zhengchenyu
   
   I agree! We've already used Netty. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [incubator-uniffle]

Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1919:
URL: https://github.com/apache/incubator-uniffle/pull/1919#issuecomment-2445827780

   @rickyma Ok, thanks for the effort before!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2745101715

   > MR/TEZ don't support Netty now. I hesitate to make it default.
   
   @jerqi I think maybe we can merge this now? I've fixed the conflicts btw.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma merged PR #1919:
URL: https://github.com/apache/uniffle/pull/1919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1651] improvement(netty): Set Netty as the default server type [uniffle]

Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #1919:
URL: https://github.com/apache/uniffle/pull/1919#issuecomment-2765916078

   > It seems the MR integretion tests for netty part have failed after setting Netty as the default server type.
   > 
   > Could you please help to fix this? I'm not familiar with MR's part. Something more might need to be done in this #2016? @qijiale76 @zhengchenyu
   
   This has nothing to do with #2016. In this pr, the default netty port is chanaged. But for grpc server which netty is disable, the netty port will be used to form the server id, then fail. See more See #2421 for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org