You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stevan Malesevic (JIRA)" <de...@myfaces.apache.org> on 2008/01/09 20:57:34 UTC

[jira] Created: (TRINIDAD-891) Locking issues coming from restore state

Locking issues coming from restore state 
-----------------------------------------

                 Key: TRINIDAD-891
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-891
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 1.2.4-core
            Reporter: Stevan Malesevic


org.apache.myfaces.trinidad.bean.util.StateUtils$Saver.restoreState  tries to load a class on every call. This is causing locking issues since SUN JVM is doing locking before it tries to load the class. 
It would be much better to use static member of ConcurrentHashMap to map name to class. This will remove the locking and speed up the processing of restore state

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TRINIDAD-891) Locking issues coming from restore state

Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564883#action_12564883 ] 

Gabrielle Crawford commented on TRINIDAD-891:
---------------------------------------------

You need to set this in web.xml to hit this code

  <context-param>
    <param-name>org.apache.myfaces.trinidad.CACHE_VIEW_ROOT</param-name>
    <param-value>false</param-value>
  </context-param>

Then run something like the inputDate component demo.

> Locking issues coming from restore state 
> -----------------------------------------
>
>                 Key: TRINIDAD-891
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-891
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.4-core
>            Reporter: Stevan Malesevic
>            Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidad.bean.util.StateUtils$Saver.restoreState  tries to load a class on every call. This is causing locking issues since SUN JVM is doing locking before it tries to load the class. 
> It would be much better to use static member of ConcurrentHashMap to map name to class. This will remove the locking and speed up the processing of restore state

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TRINIDAD-891) Locking issues coming from restore state

Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563356#action_12563356 ] 

Gabrielle Crawford commented on TRINIDAD-891:
---------------------------------------------

In general, you can not statically cache Classes as you will blow up the application if ADF Faces in running in a shared class loader and you have
cached an instance loaded from App1's ClassLoader and App2 asks for the samed named class.

This kind of caching would require that the cache be maintained in the Application Map, but the externalContext application map is backed by the servletContext, which may have its own locking issues. I have filed issue 926 to see if we can create a different app map.

See https://issues.apache.org/jira/browse/TRINIDAD-926

> Locking issues coming from restore state 
> -----------------------------------------
>
>                 Key: TRINIDAD-891
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-891
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.4-core
>            Reporter: Stevan Malesevic
>            Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidad.bean.util.StateUtils$Saver.restoreState  tries to load a class on every call. This is causing locking issues since SUN JVM is doing locking before it tries to load the class. 
> It would be much better to use static member of ConcurrentHashMap to map name to class. This will remove the locking and speed up the processing of restore state

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (TRINIDAD-891) Locking issues coming from restore state

Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabrielle Crawford resolved TRINIDAD-891.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.6-core

store a map of name->class on map returned from requestContext.getApplicationScopedAppMap()

> Locking issues coming from restore state 
> -----------------------------------------
>
>                 Key: TRINIDAD-891
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-891
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.4-core
>            Reporter: Stevan Malesevic
>            Assignee: Gabrielle Crawford
>             Fix For: 1.2.6-core
>
>
> org.apache.myfaces.trinidad.bean.util.StateUtils$Saver.restoreState  tries to load a class on every call. This is causing locking issues since SUN JVM is doing locking before it tries to load the class. 
> It would be much better to use static member of ConcurrentHashMap to map name to class. This will remove the locking and speed up the processing of restore state

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.