You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/03/11 08:25:23 UTC
[Bug 4184] New: qmail's "ESMTPA;" not detected by Received.pm
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
Summary: qmail's "ESMTPA;" not detected by Received.pm
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P3
Component: Libraries
AssignedTo: spamassassin@dostech.ca
ReportedBy: spamassassin@dostech.ca
CC: dev@spamassassin.apache.org,surf@theflow.de
As noted in bug 2462, qmail now supports RFC 3848 and somebody decided to stick
a semi-colon in the way of my regex.
http://www.fehcom.de/qmail/smtpauth.html
Received: from xdsl-81-173-228-159.netcologne.de (HELO mail.fehnet.de)
(erwin@fehcom.de@81.173.228.159)
by hamburg134 with ESMTPA; 23 Jan 2005 13:32:13 -0000
Received: (qmail 25253 invoked by uid 90); 10 Mar 2005 16:48:49 -0000
Received: from unknown (HELO ?192.168.1.20?) (webmaster@myhosting.de@80.184.166.249)
by 0 with ESMTPA; 10 Mar 2005 16:48:49 -0000
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From spamassassin-contrib@msquadrat.de 2005-03-11 05:48 -------
/ by .*? with (ESMTPA|ESMTPSA|LMTPA|LMTPSA|ASMTP|HTTP)\;? /i
Why did you escape the semicolon?
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|votes? |needs one vote
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From quinlan@pathname.com 2005-03-11 10:51 -------
Subject: Re: [review] qmail's "ESMTPA;" not detected by Received.pm
> I'll check in the optimized regex tonight after work.
I prefer the readable regexp in this case.
Daniel
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From surf@theflow.de 2005-03-11 02:51 -------
It gets flagged because of the trusted/untrusted handover code in Received.pm. I
didn't specifiy trusted_networks because this is a single host
debug message before the handover code:
received-header: parsed as [ ip=80.184.166.249 rdns=Da6f9.d.pppool.de
helo=?192.168.1.20? by=0 ident=webmaster@myhosting.de envfrom= intl=0 id=
auth=ESMTPA ]
after:
received-header: relay 80.184.166.249 trusted? no internal? no
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From spamassassin@dostech.ca 2005-03-11 08:24 -------
Subject: Re: [review] qmail's "ESMTPA;" not detected by Received.pm
Back when I first wrote it for bug 2462 I was going to use
/ by .*? with ((?:ES|L)MTPS?A|(?:ASM|HT)TP);? /i
...I can't remember why I didn't. I think it's because we kept adding
to it as we found new auth tokens.
I'll check in the optimized regex tonight after work.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Re: [Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by Daniel Quinlan <qu...@pathname.com>.
> Target Milestone => 3.0.3
By the way, I wouldn't worry about 3.0.3 unless there's a major FP issue
or a security problem.
--
Daniel Quinlan
http://www.pathname.com/~quinlan/
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|qmail's "ESMTPA;" not |[review] qmail's "ESMTPA;"
|detected by Received.pm |not detected by Received.pm
Status Whiteboard| |votes?
Target Milestone|Future |3.0.3
------- Additional Comments From spamassassin@dostech.ca 2005-03-10 23:32 -------
committed to trunk r157052
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From spamassassin@dostech.ca 2005-03-11 08:10 -------
Subject: Re: [review] qmail's "ESMTPA;" not detected by Received.pm
Originally I didn't (I've never thought there was a need for it) but
there's an existing regex in Received.pm that has one escaped... so I
sheepishly did it too in case there was something I wasn't aware of.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From automasschecker@jmason.org 2005-03-11 11:07 -------
Subject: Re: [review] qmail's "ESMTPA;" not detected by Received.pm
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
me too, FWIW -- easier to add new cases to, and easier to read.
it's not a hotspot, currently.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFCMewwMJF5cimLx9ARAuTuAKCa8+u9XBH+CcBXTykG056R/Sy6ywCbBXaJ
gyxFFYKs6PJ3EuWynY6Op90=
=PXmU
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From spamassassin-contrib@msquadrat.de 2005-03-11 11:20 -------
Yeah, the only reason why I pointed out the escaped semicolon was that it's
harder to grok (but I wasn't sure if I missed some RegExp magic which made it
necessary).
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From jm@jmason.org 2005-03-18 17:15 -------
+1 anyway, although it's very dubious we'll be doing a 3.0.3
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
parkerm@pobox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs one vote |can be committed
------- Additional Comments From parkerm@pobox.com 2005-04-22 13:29 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From spamassassin@dostech.ca 2005-03-10 23:31 -------
Created an attachment (id=2692)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2692&action=view)
patch
does this need a vote for 3.0?
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From quinlan@pathname.com 2005-03-11 00:03 -------
Subject: Re: [review] qmail's "ESMTPA;" not detected by Received.pm
> Target Milestone => 3.0.3
By the way, I wouldn't worry about 3.0.3 unless there's a major FP issue
or a security problem.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From surf@theflow.de 2005-03-11 02:45 -------
Created an attachment (id=2694)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2694&action=view)
sample message
this is a sample message which gets detected by the ESMTPA rule but flagged as
DYNABLOCK anyway
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
------- Additional Comments From kcivey@cpcug.org 2005-03-11 08:15 -------
How about condensing it to
/ by .*? with ((?:ES|L)MTPS?A|ASMTP|HTTP);? /i
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4184] [review] qmail's "ESMTPA;" not detected by Received.pm
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4184
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2005-04-24 19:25 -------
3.0 r164521
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.