You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by miomin <gi...@git.apache.org> on 2018/06/14 10:21:05 UTC

[GitHub] incubator-weex pull request #1270: [WEEX-442][Core] Fix setViewport

GitHub user miomin opened a pull request:

    https://github.com/apache/incubator-weex/pull/1270

     [WEEX-442][Core] Fix setViewport

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/miomin/incubator-weex master-bugfix-0613

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1270
    
----
commit 65308087d4f56cd79bfa7d6706f7f81e4e614b92
Author: miomin <mi...@...>
Date:   2018-06-13T11:45:44Z

    [WEEX-442][Core] Solve the problem of layout calculation accuracy

commit a55d30e556fa4fc20399e546ff42a7662c18c5a7
Author: miomin <mi...@...>
Date:   2018-06-14T10:17:43Z

    [WEEX-442][Core] Fix setViewport

commit 0c5544a135f7a9fcad4360ed938575a0b6f1cf59
Author: miomin <mi...@...>
Date:   2018-06-14T10:20:18Z

    Merge branch 'master' of https://github.com/apache/incubator-weex into master-bugfix-0613

----


---

[GitHub] incubator-weex pull request #1270: [WEEX-442][Core] Fix setViewport

Posted by miomin <gi...@git.apache.org>.
Github user miomin closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1270


---

[GitHub] incubator-weex issue #1270: [WEEX-442][Core] Fix setViewport

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1270
  
    
    <!--
      1 failure:  Code file weex_co...
      3 warning:  No Changelog chan..., Potential BREAK C..., Potential BREAK C...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>Code file weex_core/Source/android/jniprebuild/jniheader/WXBridge_jni.h does not have the copyright header.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---