You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/10/25 09:40:16 UTC

Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/
-----------------------------------------------------------

Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4492
    https://issues.apache.org/jira/browse/RANGER-4492


Repository: ranger


Description
-------

In Ranger React, we have already implemented the "plugins/definitions" API call at the initial load for optimization. 

This optimization is currently implemented on the Service Manager page and needs to be extended to the following modules:
1)Audit
2)Report
3)Security Zone
4)Key Manager

This enhancement aims to improve the initial load performance by efficiently utilizing the "plugins/definitions" API call across multiple modules within Ranger-React.


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx dc75efe50 
  security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 5f7fc8af0 
  security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx e3d09c51e 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 91d2a3758 


Diff: https://reviews.apache.org/r/74695/diff/1/


Testing
-------

Testing is in progress


Thanks,

Brijesh Bhalala


Re: Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/#review226091
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Rajpara


On Jan. 4, 2024, 5:06 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74695/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2024, 5:06 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4492
>     https://issues.apache.org/jira/browse/RANGER-4492
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In Ranger React, we have already implemented the "plugins/definitions" API call at the initial load for optimization. 
> 
> This optimization is currently implemented on the Service Manager page and needs to be extended to the following modules:
> 1)Audit
> 2)Report
> 3)Security Zone
> 4)Key Manager
> 
> This enhancement aims to improve the initial load performance by efficiently utilizing the "plugins/definitions" API call across multiple modules within Ranger-React.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx dc75efe50 
>   security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 5f7fc8af0 
>   security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx 19629d6aa 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 7eb67544d 
> 
> 
> Diff: https://reviews.apache.org/r/74695/diff/2/
> 
> 
> Testing
> -------
> 
> Tested changes on a cluster setup with Ranger Admin build with React JS code base.
> 
> 
> verified the Audit, Report, Security Zone and Key Manager Module.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>


Re: Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/#review226086
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Jan. 4, 2024, 5:06 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74695/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2024, 5:06 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4492
>     https://issues.apache.org/jira/browse/RANGER-4492
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In Ranger React, we have already implemented the "plugins/definitions" API call at the initial load for optimization. 
> 
> This optimization is currently implemented on the Service Manager page and needs to be extended to the following modules:
> 1)Audit
> 2)Report
> 3)Security Zone
> 4)Key Manager
> 
> This enhancement aims to improve the initial load performance by efficiently utilizing the "plugins/definitions" API call across multiple modules within Ranger-React.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx dc75efe50 
>   security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 5f7fc8af0 
>   security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx 19629d6aa 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 7eb67544d 
> 
> 
> Diff: https://reviews.apache.org/r/74695/diff/2/
> 
> 
> Testing
> -------
> 
> Tested changes on a cluster setup with Ranger Admin build with React JS code base.
> 
> 
> verified the Audit, Report, Security Zone and Key Manager Module.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>


Re: Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/
-----------------------------------------------------------

(Updated Jan. 4, 2024, 5:06 a.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4492
    https://issues.apache.org/jira/browse/RANGER-4492


Repository: ranger


Description
-------

In Ranger React, we have already implemented the "plugins/definitions" API call at the initial load for optimization. 

This optimization is currently implemented on the Service Manager page and needs to be extended to the following modules:
1)Audit
2)Report
3)Security Zone
4)Key Manager

This enhancement aims to improve the initial load performance by efficiently utilizing the "plugins/definitions" API call across multiple modules within Ranger-React.


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx dc75efe50 
  security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 5f7fc8af0 
  security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx 19629d6aa 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 7eb67544d 


Diff: https://reviews.apache.org/r/74695/diff/2/


Testing (updated)
-------

Tested changes on a cluster setup with Ranger Admin build with React JS code base.


verified the Audit, Report, Security Zone and Key Manager Module.


Thanks,

Brijesh Bhalala


Re: Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/
-----------------------------------------------------------

(Updated Dec. 12, 2023, 1:40 p.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4492
    https://issues.apache.org/jira/browse/RANGER-4492


Repository: ranger


Description
-------

In Ranger React, we have already implemented the "plugins/definitions" API call at the initial load for optimization. 

This optimization is currently implemented on the Service Manager page and needs to be extended to the following modules:
1)Audit
2)Report
3)Security Zone
4)Key Manager

This enhancement aims to improve the initial load performance by efficiently utilizing the "plugins/definitions" API call across multiple modules within Ranger-React.


Diffs (updated)
-----

  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx dc75efe50 
  security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 5f7fc8af0 
  security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx 19629d6aa 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 7eb67544d 


Diff: https://reviews.apache.org/r/74695/diff/2/

Changes: https://reviews.apache.org/r/74695/diff/1-2/


Testing
-------

Testing is in progress


Thanks,

Brijesh Bhalala