You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/03/23 01:26:48 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #7674: [INLONG-7673][Manager] Remove whitespace when saving mysql jdbcUrl

fuweng11 opened a new pull request, #7674:
URL: https://github.com/apache/inlong/pull/7674

   ### Prepare a Pull Request
   
   - Fixes #7673 
   
   ### Motivation
   
   Remove whitespace when saving mysql jdbcUrl to avoid circumventing sensitive parameters.
   
   ### Modifications
   
   Remove whitespace when saving mysql jdbcUrl.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving mysql jdbcUrl

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7674:
URL: https://github.com/apache/inlong/pull/7674#discussion_r1145636121


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java:
##########
@@ -221,7 +221,7 @@ public static String filterSensitive(String url) {
             return url;
         }
         try {
-            String resultUrl = url;
+            String resultUrl = url.replaceAll(InlongConstants.BLANK, "");

Review Comment:
   Please check other urls at the same time, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow merged PR #7674:
URL: https://github.com/apache/inlong/pull/7674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on PR #7674:
URL: https://github.com/apache/inlong/pull/7674#issuecomment-1484903745

   > @fuweng11 Please update decription. Because you modify other file.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on a diff in pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7674:
URL: https://github.com/apache/inlong/pull/7674#discussion_r1148936286


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java:
##########
@@ -221,7 +221,7 @@ public static String filterSensitive(String url) {
             return url;
         }
         try {
-            String resultUrl = url;
+            String resultUrl = url.replaceAll(InlongConstants.BLANK, "");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7674:
URL: https://github.com/apache/inlong/pull/7674#issuecomment-1484351747

   @fuweng11 please fix the failed UT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7674:
URL: https://github.com/apache/inlong/pull/7674#discussion_r1148758318


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java:
##########
@@ -221,7 +221,7 @@ public static String filterSensitive(String url) {
             return url;
         }
         try {
-            String resultUrl = url;
+            String resultUrl = url.replaceAll(InlongConstants.BLANK, "");

Review Comment:
   @fuweng11 I think we should replace/trim the data when it comes in.
   Because the external data is untrustworthy, it is processed uniformly when it enters the system;
   
   Once the data is saved in the DB of our system, the data transferring within the system should be regarded as credible data and does not need to be processed repeatedly in every place of use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7674:
URL: https://github.com/apache/inlong/pull/7674#issuecomment-1484861020

   @fuweng11 Please update decription. Because you modify other file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org