You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sanjana Kaundinya <sk...@gmail.com> on 2020/03/23 17:50:15 UTC
[VOTE] KIP-580: Exponential Backoff for Kafka Clients
Hi Everyone,
I’d like to start a vote for KIP-580: Exponential Backoff for Kafka Clients. The link to the KIP can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients.
Thanks,
Sanjana
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Jason Gustafson <ja...@confluent.io>.
+1 Thanks for the KIP!
On Tue, Mar 24, 2020 at 10:31 AM Boyang Chen <re...@gmail.com>
wrote:
> +1 (non-binding).
>
> agree with Guozhang for the warning.
>
> On Tue, Mar 24, 2020 at 9:57 AM Guozhang Wang <wa...@gmail.com> wrote:
>
> > +1 (binding).
> >
> > One minor thing is that upon starting, when we find the specified
> > `max.backoff` config < `backoff`, we can log a warning message.
> >
> >
> > Guozhang
> >
> > On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash <
> > kamal.chandraprakash@gmail.com> wrote:
> >
> > > +1 (non-binding). Thanks for the KIP!
> > >
> > > On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya <
> skaundinya@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi Everyone,
> > > >
> > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > > Clients. The link to the KIP can be found here:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > > .
> > > >
> > > > Thanks,
> > > > Sanjana
> > > >
> > > >
> > >
> >
> >
> > --
> > -- Guozhang
> >
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Boyang Chen <re...@gmail.com>.
+1 (non-binding).
agree with Guozhang for the warning.
On Tue, Mar 24, 2020 at 9:57 AM Guozhang Wang <wa...@gmail.com> wrote:
> +1 (binding).
>
> One minor thing is that upon starting, when we find the specified
> `max.backoff` config < `backoff`, we can log a warning message.
>
>
> Guozhang
>
> On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash <
> kamal.chandraprakash@gmail.com> wrote:
>
> > +1 (non-binding). Thanks for the KIP!
> >
> > On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya <skaundinya@gmail.com
> >
> > wrote:
> >
> > > Hi Everyone,
> > >
> > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > Clients. The link to the KIP can be found here:
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > .
> > >
> > > Thanks,
> > > Sanjana
> > >
> > >
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Guozhang Wang <wa...@gmail.com>.
+1 (binding).
One minor thing is that upon starting, when we find the specified
`max.backoff` config < `backoff`, we can log a warning message.
Guozhang
On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash <
kamal.chandraprakash@gmail.com> wrote:
> +1 (non-binding). Thanks for the KIP!
>
> On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya <sk...@gmail.com>
> wrote:
>
> > Hi Everyone,
> >
> > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > Clients. The link to the KIP can be found here:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > .
> >
> > Thanks,
> > Sanjana
> >
> >
>
--
-- Guozhang
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Kamal Chandraprakash <ka...@gmail.com>.
+1 (non-binding). Thanks for the KIP!
On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya <sk...@gmail.com>
wrote:
> Hi Everyone,
>
> I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> Clients. The link to the KIP can be found here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> .
>
> Thanks,
> Sanjana
>
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Sanjana Kaundinya <sk...@gmail.com>.
Thank you to all that voted. I have 4 binding votes and 4 non-binding votes. I will begin work on this KIP soon.
Thanks,
Sanjana
On Mar 26, 2020, 3:03 PM -0700, Konstantine Karantasis <ko...@confluent.io>, wrote:
> Thank you Sanjana!
>
> +1 (binding) from me too.
>
> Konstantine
>
>
> On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya <sk...@gmail.com>
> wrote:
>
> > Hi Konstantine,
> >
> > Thanks for the feedback, I have addressed it on the [DISCUSS] thread and
> > will update the KIP shortly.
> >
> > Thanks,
> > Sanjana
> > On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis <
> > konstantine@confluent.io>, wrote:
> > > Hi Sanjana.
> > > Thanks for the KIP! Seems quite useful not to overwhelm the brokers with
> > > the described requests from clients.
> > >
> > > You have the votes already, and I'm also in favor overall, but I've made
> > a
> > > couple of questions (sorry for the delay) regarding Connect, which is
> > also
> > > using retry.backoff.ms but currently is not mentioned in the KIP, as
> > well
> > > as a question around how we expect the new setting to work with
> > rebalances
> > > in clients that inherit from the AbstractCoordinator (Consumer and
> > Connect
> > > at a minimum).
> > >
> > > Maybe it's worth clarifying these points in the KIP, or the mailing list
> > > thread in case I missed something w/r/t the intent of the changes.
> > >
> > > Best,
> > > Konstantine
> > >
> > >
> > > On Tue, Mar 24, 2020 at 9:42 PM David Jacot <dj...@confluent.io> wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > Thanks for the KIP, great improvement!
> > > >
> > > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira <gw...@confluent.io> a
> > écrit :
> > > >
> > > > > +1 (binding) - thank you
> > > > >
> > > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <
> > skaundinya@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hi Everyone,
> > > > > >
> > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > > > > Clients. The link to the KIP can be found here:
> > > > > >
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > > > > .
> > > > > >
> > > > > > Thanks,
> > > > > > Sanjana
> > > > > >
> > > > > >
> > > > >
> > > >
> >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Konstantine Karantasis <ko...@confluent.io>.
Thank you Sanjana!
+1 (binding) from me too.
Konstantine
On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya <sk...@gmail.com>
wrote:
> Hi Konstantine,
>
> Thanks for the feedback, I have addressed it on the [DISCUSS] thread and
> will update the KIP shortly.
>
> Thanks,
> Sanjana
> On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis <
> konstantine@confluent.io>, wrote:
> > Hi Sanjana.
> > Thanks for the KIP! Seems quite useful not to overwhelm the brokers with
> > the described requests from clients.
> >
> > You have the votes already, and I'm also in favor overall, but I've made
> a
> > couple of questions (sorry for the delay) regarding Connect, which is
> also
> > using retry.backoff.ms but currently is not mentioned in the KIP, as
> well
> > as a question around how we expect the new setting to work with
> rebalances
> > in clients that inherit from the AbstractCoordinator (Consumer and
> Connect
> > at a minimum).
> >
> > Maybe it's worth clarifying these points in the KIP, or the mailing list
> > thread in case I missed something w/r/t the intent of the changes.
> >
> > Best,
> > Konstantine
> >
> >
> > On Tue, Mar 24, 2020 at 9:42 PM David Jacot <dj...@confluent.io> wrote:
> >
> > > +1 (non-binding)
> > >
> > > Thanks for the KIP, great improvement!
> > >
> > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira <gw...@confluent.io> a
> écrit :
> > >
> > > > +1 (binding) - thank you
> > > >
> > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <
> skaundinya@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi Everyone,
> > > > >
> > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > > > Clients. The link to the KIP can be found here:
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > > > .
> > > > >
> > > > > Thanks,
> > > > > Sanjana
> > > > >
> > > > >
> > > >
> > >
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Sanjana Kaundinya <sk...@gmail.com>.
Hi Konstantine,
Thanks for the feedback, I have addressed it on the [DISCUSS] thread and will update the KIP shortly.
Thanks,
Sanjana
On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis <ko...@confluent.io>, wrote:
> Hi Sanjana.
> Thanks for the KIP! Seems quite useful not to overwhelm the brokers with
> the described requests from clients.
>
> You have the votes already, and I'm also in favor overall, but I've made a
> couple of questions (sorry for the delay) regarding Connect, which is also
> using retry.backoff.ms but currently is not mentioned in the KIP, as well
> as a question around how we expect the new setting to work with rebalances
> in clients that inherit from the AbstractCoordinator (Consumer and Connect
> at a minimum).
>
> Maybe it's worth clarifying these points in the KIP, or the mailing list
> thread in case I missed something w/r/t the intent of the changes.
>
> Best,
> Konstantine
>
>
> On Tue, Mar 24, 2020 at 9:42 PM David Jacot <dj...@confluent.io> wrote:
>
> > +1 (non-binding)
> >
> > Thanks for the KIP, great improvement!
> >
> > Le mer. 25 mars 2020 à 04:44, Gwen Shapira <gw...@confluent.io> a écrit :
> >
> > > +1 (binding) - thank you
> > >
> > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <sk...@gmail.com>
> > > wrote:
> > >
> > > > Hi Everyone,
> > > >
> > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > > Clients. The link to the KIP can be found here:
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > > .
> > > >
> > > > Thanks,
> > > > Sanjana
> > > >
> > > >
> > >
> >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Konstantine Karantasis <ko...@confluent.io>.
Hi Sanjana.
Thanks for the KIP! Seems quite useful not to overwhelm the brokers with
the described requests from clients.
You have the votes already, and I'm also in favor overall, but I've made a
couple of questions (sorry for the delay) regarding Connect, which is also
using retry.backoff.ms but currently is not mentioned in the KIP, as well
as a question around how we expect the new setting to work with rebalances
in clients that inherit from the AbstractCoordinator (Consumer and Connect
at a minimum).
Maybe it's worth clarifying these points in the KIP, or the mailing list
thread in case I missed something w/r/t the intent of the changes.
Best,
Konstantine
On Tue, Mar 24, 2020 at 9:42 PM David Jacot <dj...@confluent.io> wrote:
> +1 (non-binding)
>
> Thanks for the KIP, great improvement!
>
> Le mer. 25 mars 2020 à 04:44, Gwen Shapira <gw...@confluent.io> a écrit :
>
> > +1 (binding) - thank you
> >
> > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <sk...@gmail.com>
> > wrote:
> >
> > > Hi Everyone,
> > >
> > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > > Clients. The link to the KIP can be found here:
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > > .
> > >
> > > Thanks,
> > > Sanjana
> > >
> > >
> >
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by David Jacot <dj...@confluent.io>.
+1 (non-binding)
Thanks for the KIP, great improvement!
Le mer. 25 mars 2020 à 04:44, Gwen Shapira <gw...@confluent.io> a écrit :
> +1 (binding) - thank you
>
> On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <sk...@gmail.com>
> wrote:
>
> > Hi Everyone,
> >
> > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> > Clients. The link to the KIP can be found here:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> > .
> >
> > Thanks,
> > Sanjana
> >
> >
>
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding) - thank you
On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya <sk...@gmail.com>
wrote:
> Hi Everyone,
>
> I’d like to start a vote for KIP-580: Exponential Backoff for Kafka
> Clients. The link to the KIP can be found here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients
> .
>
> Thanks,
> Sanjana
>
>