You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/31 03:08:30 UTC

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10561: add global rule changed listener factory,update governance doc

menghaoranss commented on a change in pull request #10561:
URL: https://github.com/apache/shardingsphere/pull/10561#discussion_r642183958



##########
File path: shardingsphere-governance/shardingsphere-governance-core/src/main/resources/META-INF/services/org.apache.shardingsphere.governance.core.registry.listener.GovernanceListenerFactory
##########
@@ -20,3 +20,4 @@ org.apache.shardingsphere.governance.core.registry.listener.factory.DataSourceSt
 org.apache.shardingsphere.governance.core.registry.listener.factory.LockChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.PropertiesChangedListenerFactory
 org.apache.shardingsphere.governance.core.registry.listener.factory.MetaDataChangedListenerFactory
+org.apache.shardingsphere.governance.core.registry.listener.factory.GlobalRuleChangedListenerFactory

Review comment:
       Could you add UT for GlobalRuleChangedListenerFactor and other factories, you can fix them in next PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org