You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrew Muldowney (JIRA)" <ji...@apache.org> on 2013/07/22 23:22:51 UTC
[jira] [Comment Edited] (SOLR-2894) Implement distributed pivot
faceting
[ https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715674#comment-13715674 ]
Andrew Muldowney edited comment on SOLR-2894 at 7/22/13 9:22 PM:
-----------------------------------------------------------------
Built on 4_4
This version fixes the following:
1) Indecisive faceting not being respected on refinement queries
2) Key not being respected
3) Facet.offset not being respected
4) datetimes breaking when trying to refine
One point of contention is this:
The SolrExampleTests.java (for the SolrJ stuff) had a check that required pivot facet boolean results as strict Boolean.TRUE as opposed to the string "true".
This came about from the change that was required to fix datetime.
I can't find anywhere else where we require a boolean field's value to equal Boolean.True so I think this test was just an artifact of how the original pivot facetting code was written.
As it stands now the SolrExampleTests.doPivotFacetTest:1151 has been changed to "true" instead of Boolean.TRUE
was (Author: andrew.muldowney):
This version fixes the following:
1) Indecisive faceting not being respected on refinement queries
2) Key not being respected
3) Facet.offset not being respected
4) datetimes breaking when trying to refine
One point of contention is this:
The SolrExampleTests.java (for the SolrJ stuff) had a check that required pivot facet boolean results as strict Boolean.TRUE as opposed to the string "true".
This came about from the change that was required to fix datetime.
I can't find anywhere else where we require a boolean field's value to equal Boolean.True so I think this test was just an artifact of how the original pivot facetting code was written.
As it stands now the SolrExampleTests.doPivotFacetTest:1151 has been changed to "true" instead of Boolean.TRUE
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Fix For: 4.5
>
> Attachments: SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894-reworked.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org