You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 05:31:55 UTC

[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0

houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487


   I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_rust.py#L88-L96.
   
   But this particular logging line was removed in this PR, so the the test runner passed the wrong port to the consumer client.
   
   We need to add back that logging and also make a comment there to let future developer know this is just an informational print ;)
   
   In https://github.com/apache/arrow/pull/9241, I used tokio-stream wrapper to workaround this issue. But perhaps there is a better to do get the binding port from sonic without creating our own TCP listener manually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org