You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/07/19 10:49:56 UTC
Review Request 71123: Made openssl configuration in 'configure.ac'
occur earlier.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71123/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
Repository: mesos
Description
-------
The `AC_CHECK_LIBS()` call has a side effect of adding the
found libraries to the linker command line by default. In
addition, our custom configuration code also adds any
non-default include and library search paths to `LDFLAGS`
and `CPPFLAGS`.
Since many of our third-party dependencies depend themselves
on openssl, the configuration check for openssl should be
early during the configuration so that later libraries can
be built against the same version of openssl that is used
for the Mesos build itself.
According to the instructions given at
https://www.gnu.org/software/autoconf/manual/autoconf-2.67
/html_node/Libraries.html
reordering the calls to `AC_CHECK_LIB()` is a preferrable solution
to passing in `-lssl -lcrypto` as the `other-libraries` argument.
Diffs
-----
configure.ac 4635bb38b6b65ea0454cfbde31b681a6ce232e10
Diff: https://reviews.apache.org/r/71123/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71123: Made openssl configuration in
'configure.ac' occur earlier.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71123/#review216765
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On July 19, 2019, 10:49 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71123/
> -----------------------------------------------------------
>
> (Updated July 19, 2019, 10:49 a.m.)
>
>
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `AC_CHECK_LIBS()` call has a side effect of adding the
> found libraries to the linker command line by default. In
> addition, our custom configuration code also adds any
> non-default include and library search paths to `LDFLAGS`
> and `CPPFLAGS`.
>
> Since many of our third-party dependencies depend themselves
> on openssl, the configuration check for openssl should be
> early during the configuration so that later libraries can
> be built against the same version of openssl that is used
> for the Mesos build itself.
>
> According to the instructions given at
>
> https://www.gnu.org/software/autoconf/manual/autoconf-2.67
> /html_node/Libraries.html
>
> reordering the calls to `AC_CHECK_LIB()` is a preferrable solution
> to passing in `-lssl -lcrypto` as the `other-libraries` argument.
>
>
> Diffs
> -----
>
> configure.ac 4635bb38b6b65ea0454cfbde31b681a6ce232e10
>
>
> Diff: https://reviews.apache.org/r/71123/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>