You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/03/30 22:05:22 UTC

[GitHub] [accumulo] keith-turner commented on a diff in pull request #3261: fixes #3260 by making cached split info a softref

keith-turner commented on code in PR #3261:
URL: https://github.com/apache/accumulo/pull/3261#discussion_r1153834034


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1821,7 +1822,8 @@ private SplitComputations(Set<FileRef> inputFiles, SortedMap<Double,Key> midPoin
     }
   }
 
-  private AtomicReference<SplitComputations> lastSplitComputation = new AtomicReference<>();
+  private volatile SoftReference<SplitComputations> lastSplitComputation =
+      new SoftReference<>(null);

Review Comment:
   changed in [682832a](https://github.com/apache/accumulo/pull/3261/commits/682832a88b58f109b60aae38edd3ff215b7b6708)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org