You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/03 18:01:52 UTC
[GitHub] [arrow] abreis opened a new pull request #9407: [ARROW-11484]: [Rust][DataFusion] Derive Clone for ExecutionContext
abreis opened a new pull request #9407:
URL: https://github.com/apache/arrow/pull/9407
This derives `Clone` for `ExecutionContext`, which should be safe since it itself is an `Arc` wrapper.
I took the opportunity to freshen up a few doc comments along the way, writing them in the same style that Rust's stdlib uses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#issuecomment-772755626
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#issuecomment-773280216
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=h1) Report
> Merging [#9407](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=desc) (24a75ca) into [master](https://codecov.io/gh/apache/arrow/commit/ac18524c74a51a50a97ab1bff0c7e1c28aafbbdc?el=desc) (ac18524) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9407 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 230 230
Lines 54053 54053
=======================================
Hits 44388 44388
Misses 9665 9665
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9407/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.21% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=footer). Last update [ac18524...24a75ca](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9407:
URL: https://github.com/apache/arrow/pull/9407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#issuecomment-773280216
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=h1) Report
> Merging [#9407](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=desc) (24a75ca) into [master](https://codecov.io/gh/apache/arrow/commit/ac18524c74a51a50a97ab1bff0c7e1c28aafbbdc?el=desc) (ac18524) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9407 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 230 230
Lines 54053 54053
=======================================
Hits 44388 44388
Misses 9665 9665
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9407/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.21% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=footer). Last update [ac18524...24a75ca](https://codecov.io/gh/apache/arrow/pull/9407?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#issuecomment-772755626
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abreis commented on a change in pull request #9407: [ARROW-11484]: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
abreis commented on a change in pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#discussion_r569633669
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -119,7 +120,7 @@ impl ExecutionContext {
}
}
- /// of RecordBatch instances)
+ /// Creates a dataframe that will execute a SQL query.
Review comment:
Please review. My understanding is that this does not execute the query immediately, but creates a plan for it.
The original comment was from v1.0.1: `Execute a SQL query and produce a Relation (a schema-aware iterator over a series of RecordBatch instances)`. By v2.0.0 the methods was returning a `DataFrame` (not `RecordBatch`es), and by v3.0.0 the comment was mangled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9407: [ARROW-11484]: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#discussion_r569649105
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -119,7 +120,7 @@ impl ExecutionContext {
}
}
- /// of RecordBatch instances)
+ /// Creates a dataframe that will execute a SQL query.
Review comment:
Good point. Yes, this solely creates `DataFrame` corresponding to the passed SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9407: ARROW-11484: [Rust][DataFusion] Derive Clone for ExecutionContext
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9407:
URL: https://github.com/apache/arrow/pull/9407#issuecomment-772777844
https://issues.apache.org/jira/browse/ARROW-11484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org