You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2025/06/25 09:25:56 UTC

[PR] [SPARK-52574][TESTS] Ensure compression codec is correctly applied in Hive tables and dirs [spark]

wangyum opened a new pull request, #51279:
URL: https://github.com/apache/spark/pull/51279

   ### What changes were proposed in this pull request?
   
   This PR adds a test to verify that the compression codec specified in `spark.sql.parquet.compression.codec` is correctly applied to Hive tables and directories during table creation and data insertion.
   
   ### Why are the changes needed?
   
   We add compression codec through `setupHadoopConfForCompression` and keep compress codec in hadoopConf:
   https://github.com/apache/spark/blob/3e0808c33f185c13808ce2d547ce9ba0057d31a6/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/V1WritesHiveUtils.scala#L114-L141
   
   However, we might accidentally use `sparkSession.sessionState.newHadoopConf()` instead of the old hadoopConf. This can cause the compression codec to be lost. So, we add a test to make sure this does not happen.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manual test.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52574][SQL][TESTS] Ensure compression codec is correctly applied in Hive tables and dirs [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #51279: [SPARK-52574][SQL][TESTS] Ensure compression codec is correctly applied in Hive tables and dirs
URL: https://github.com/apache/spark/pull/51279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org