You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/25 01:59:48 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #791: Use PutVarInt instead of PutFixed while encoding stream entry value

git-hulk commented on PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#issuecomment-1226681148

   @torwig Thanks for your contribution. As @ShooterIT mentioned that we don't promise stability and compatibility before releasing, so feel free to do that.
   
   @ShooterIT Those Put|GetFixedXXX are NOT copied from rocksdb/leveldb indeed, we rewritten them into BIGENDIAN while the rocksdb is little endian, so I think it's good to keep Apache 2.0 statement only. https://github.com/facebook/rocksdb/blob/0050a73a4fb1ba52d78655b271a0f09ba1fbf7fc/util/coding_lean.h#L25
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org