[GitHub] [shardingsphere] sandynz commented on a change in pull request #14767: For #14733：Fix PostgreSQL 14 money data type are abnormal during full migration

[GitBox <gi...@apache.org>]

sandynz commented on a change in pull request #14767:
URL: https://github.com/apache/shardingsphere/pull/14767#discussion_r784636425



##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/AbstractInventoryDumper.java
##########
@@ -183,9 +186,20 @@ private long getPositionEndValue(final IngestPosition<?> position) {
     protected abstract PreparedStatement createPreparedStatement(Connection connection, String sql) throws SQLException;
     
     protected Object readValue(final ResultSet resultSet, final int index) throws SQLException {
+        if (isPgMoneyType(resultSet, index)) {
+            return resultSet.getBigDecimal(index);
+        }

Review comment:
       It's better to put this snippet into `PostgreSQLInventoryDumper`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org