You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/25 23:45:13 UTC

[GitHub] [netbeans] timboudreau opened a new pull request #2711: Popup tab switcher should hide when another application steals focus

timboudreau opened a new pull request #2711:
URL: https://github.com/apache/netbeans/pull/2711


   Fixes a problem I've run into several times on Mac OS - if another application steals focus
   while the popup switcher is open, the switcher can wind up in a state where it is listening
   twice, and is hidden as soon as you release the mouse button.
   
   Fix is to add AWTEvent.WINDOW_EVENT_MASK to the set of AWTEvents listened for, check that
   there really is no active window (to avoid confusion around heavyweight AWT popups) and
   hide the popup in that case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on a change in pull request #2711: Popup tab switcher should hide when another application steals focus

Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2711:
URL: https://github.com/apache/netbeans/pull/2711#discussion_r576600012



##########
File path: platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/ButtonPopupSwitcher.java
##########
@@ -21,11 +21,13 @@
 
 import java.awt.AWTEvent;
 import java.awt.Component;
+import static java.awt.KeyboardFocusManager.getCurrentKeyboardFocusManager;

Review comment:
       Unusual ;) in NB coding style.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2711: Popup tab switcher should hide when another application steals focus

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2711:
URL: https://github.com/apache/netbeans/pull/2711#issuecomment-809675695


   Seems no reason not to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw merged pull request #2711: Popup tab switcher should hide when another application steals focus

Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2711:
URL: https://github.com/apache/netbeans/pull/2711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on pull request #2711: Popup tab switcher should hide when another application steals focus

Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2711:
URL: https://github.com/apache/netbeans/pull/2711#issuecomment-779650130


   @timboudreau should this go to 12.4 (attach to a milestone) ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists