You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/05/09 11:07:57 UTC
Review Request 21259: CLOUDSTACK-6399: VMSync thread does not run if all the
VMs on a host are stopped from outside CS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21259/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6399
https://issues.apache.org/jira/browse/CLOUDSTACK-6399
Repository: cloudstack-git
Description
-------
when there are no vms running on hyperv host, then was returning null which has different meaning. Now returning empty list of hostvmstatereport
Diffs
-----
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 7888e43
Diff: https://reviews.apache.org/r/21259/diff/
Testing
-------
verified when there are no vms on host, then vmsync thread is running fine
Thanks,
Anshul Gangwar
Re: Review Request 21259: CLOUDSTACK-6399: VMSync thread does not run if all
the VMs on a host are stopped from outside CS
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21259/#review42562
-----------------------------------------------------------
Commit 704f6d8279c314a165199804ee43eaac4b0d482a in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=704f6d8 ]
CLOUDSTACK-6399: When there are no vms running on hyperv host, then agent was returning null. In
that case cloudstack was not doing anything and not updating the state of the vms to stopped.
Now the agent returns empty list of hostvmstatereport. Management server will then update the
vm state to stopped (instead of not acting upon the return state).
- ASF Subversion and Git Services
On May 9, 2014, 9:07 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21259/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6399
> https://issues.apache.org/jira/browse/CLOUDSTACK-6399
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> when there are no vms running on hyperv host, then was returning null which has different meaning. Now returning empty list of hostvmstatereport
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 7888e43
>
> Diff: https://reviews.apache.org/r/21259/diff/
>
>
> Testing
> -------
>
> verified when there are no vms on host, then vmsync thread is running fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21259: CLOUDSTACK-6399: VMSync thread does not run if all
the VMs on a host are stopped from outside CS
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21259/#review42567
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On May 9, 2014, 9:07 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21259/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6399
> https://issues.apache.org/jira/browse/CLOUDSTACK-6399
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> when there are no vms running on hyperv host, then was returning null which has different meaning. Now returning empty list of hostvmstatereport
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 7888e43
>
> Diff: https://reviews.apache.org/r/21259/diff/
>
>
> Testing
> -------
>
> verified when there are no vms on host, then vmsync thread is running fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21259: CLOUDSTACK-6399: VMSync thread does not run if all
the VMs on a host are stopped from outside CS
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21259/#review42564
-----------------------------------------------------------
Commit 7916542d99e858a62b236d2ef34232ba2e36d4f0 in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7916542 ]
CLOUDSTACK-6399: When there are no vms running on hyperv host, then agent was returning null. In
that case cloudstack was not doing anything and not updating the state of the vms to stopped.
Now the agent returns empty list of hostvmstatereport. Management server will then update the
vm state to stopped (instead of not acting upon the return state).
- ASF Subversion and Git Services
On May 9, 2014, 9:07 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21259/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6399
> https://issues.apache.org/jira/browse/CLOUDSTACK-6399
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> when there are no vms running on hyperv host, then was returning null which has different meaning. Now returning empty list of hostvmstatereport
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 7888e43
>
> Diff: https://reviews.apache.org/r/21259/diff/
>
>
> Testing
> -------
>
> verified when there are no vms on host, then vmsync thread is running fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21259: CLOUDSTACK-6399: VMSync thread does not run if all
the VMs on a host are stopped from outside CS
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21259/#review42673
-----------------------------------------------------------
Commit 55398ee185573d1d2177be8225d36ba74ae6a4f2 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=55398ee ]
CLOUDSTACK-6399: When there are no vms running on hyperv host, then agent was returning null. In
that case cloudstack was not doing anything and not updating the state of the vms to stopped.
Now the agent returns empty list of hostvmstatereport. Management server will then update the
vm state to stopped (instead of not acting upon the return state).
- ASF Subversion and Git Services
On May 9, 2014, 9:07 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21259/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6399
> https://issues.apache.org/jira/browse/CLOUDSTACK-6399
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> when there are no vms running on hyperv host, then was returning null which has different meaning. Now returning empty list of hostvmstatereport
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 7888e43
>
> Diff: https://reviews.apache.org/r/21259/diff/
>
>
> Testing
> -------
>
> verified when there are no vms on host, then vmsync thread is running fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>