You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/17 05:18:49 UTC
[GitHub] [pulsar] freeznet opened a new pull request #12847: [package management service] check service status before run commands
freeznet opened a new pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847
### Motivation
`pulsar-admin` runs packages management services commands, but if the broker is not enabled the service, it will throw NPE.
The root cause is https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java#L45-L47, the `PackagesManagement` might be null if the service is not enabled.
### Modifications
Check `isEnablePackagesManagement` before each internal request.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847#issuecomment-971200674
@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847#issuecomment-971201395
@nlu90 please help to review when you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847#issuecomment-971200723
@freeznet:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet edited a comment on pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
freeznet edited a comment on pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847#issuecomment-972555920
@nlu90 good idea, IIRC the functions endpoints will return `UnsupportedOperationException` if no functions worker enabled, this reminds me that it might be helpful to improve the code quality with this PR.
I have changed this PR and removed some duplicating code, PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12847: [package management service] check service status before run commands
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12847:
URL: https://github.com/apache/pulsar/pull/12847#issuecomment-972555920
@nlu90 good idea, IIRC the functions API will return `UnsupportedOperationException` if no functions worker enabled, this reminds me that it might be helpful to improve the code quality with this PR.
I have changed this PR and removed some duplicating code, PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org