You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by James McCoy <ja...@debian.org> on 2014/01/17 05:23:26 UTC

Invalid Makefile.PL generated if --enable-sqlite-compatibility-version specified

When --enable-sqlite-compatibility-version is used, the configure script
ends up defining CFLAGS such that it contains

    -DSVN_SQLITE_MIN_VERSION='"X.Y.Z"'

This string then makes it into the generated
subversion/bindings/swig/perl/native/Makefile.PL as

    my $cflags = '… -DSVN_SQLITE_MIN_VERSION='"X.Y.Z"' …';

which causes the perl script to have invalid syntax:

    cd ./subversion/bindings/swig/perl/native; \
                    /usr/bin/perl Makefile.PL INSTALLDIRS=vendor; \
                    sed -i -e '/^LD_RUN_PATH/s/^/#/' Makefile Makefile.[a-z]*
    String found where operator expected at Makefile.PL line 55, near "'-DSVN_SQLITE_MIN_VERSION_NUMBER=3007012 -DSVN_SQLITE_MIN_VERSION='"3.7.12""
            (Missing operator before "3.7.12"?)
    String found where operator expected at Makefile.PL line 55, near ""3.7.12"' -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security   -pthread'"
            (Missing operator before ' -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security   -pthread'?)
    syntax error at Makefile.PL line 55, near "'-DSVN_SQLITE_MIN_VERSION_NUMBER=3007012 -DSVN_SQLITE_MIN_VERSION='"3.7.12""
    Execution of Makefile.PL aborted due to compilation errors.

The attached patch fixes the issue for me.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <ja...@debian.org>

Re: Invalid Makefile.PL generated if --enable-sqlite-compatibility-version specified

Posted by Ben Reser <be...@reser.org>.
On 1/16/14, 8:23 PM, James McCoy wrote:
> When --enable-sqlite-compatibility-version is used, the configure script
> ends up defining CFLAGS such that it contains
> 
>     -DSVN_SQLITE_MIN_VERSION='"X.Y.Z"'

...

> The attached patch fixes the issue for me.

Commited your patch in r1559009, backport nominated for 1.8.x.

Thanks, I couldn't think of a less ugly fix.  We probably should do the same
for the rest of the autoconf replacements, though most of them are pretty
unlikely to have this sort of issue.