[jira] [Commented] (AIRFLOW-3741) oracle_hook not support specific encoding

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751786#comment-16751786 ] 

ASF GitHub Bot commented on AIRFLOW-3741:
-----------------------------------------

zhongjiajie commented on pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook
URL: https://github.com/apache/airflow/pull/4584
 
 
   Add extra config to Oracle hook
   including encoding, mode, threaded etc
   
   Add Oracle hook unittest
   
   Add docs in insert_rows and
   bulk_insert_rows
   
   Fix Oracle hook bulk_insert_rows bug
   when target_fields use default None
   value
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3741
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Add extra config to Oracle hook
   
   ### Tests
   
   - [x] My PR adds the following unit tests : 
   
   test_oracle_hook.py
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> oracle_hook not support specific encoding
> -----------------------------------------
>
>                 Key: AIRFLOW-3741
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3741
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: hooks
>    Affects Versions: 1.10.1
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Major
>              Labels: features
>
> oracle_hook get_conn block just like below
>  
> {code:java}
> if dsn and sid and not service_name:
>     dsn = cx_Oracle.makedsn(dsn, conn.port, sid)
>     conn = cx_Oracle.connect(conn.login, conn.password, dsn=dsn)
> elif dsn and service_name and not sid:
>     dsn = cx_Oracle.makedsn(dsn, conn.port, service_name=service_name)
>     conn = cx_Oracle.connect(conn.login, conn.password, dsn=dsn)
> else:
>     conn = cx_Oracle.connect(conn.login, conn.password, conn.host){code}
>  
> oracle_hook only support default encoding, not UTF-8.
> In cx_oracle [official doc|https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect] and [github issue|https://github.com/oracle/python-cx_Oracle/issues/157] we know how to set connection encoding. I think is necessary add this feature to oracle_hook



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)