[GitHub] [airflow] dstandish commented on a change in pull request #19904: Fix labels used to find queued KubeExecutor pods

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #19904:
URL: https://github.com/apache/airflow/pull/19904#discussion_r759674661



##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -473,7 +472,7 @@ def clear_not_launched_queued_tasks(self, session=None) -> None:
             base_label_selector = (
                 f"dag_id={pod_generator.make_safe_label_value(task.dag_id)},"
                 f"task_id={pod_generator.make_safe_label_value(task.task_id)},"
-                f"airflow-worker={pod_generator.make_safe_label_value(str(self.scheduler_job_id))}"
+                f"airflow-worker={pod_generator.make_safe_label_value(str(task.queued_by_job_id))}"

Review comment:
       what if the scenario is this
   
   pod is created, scheduler dies
   
   scheduler back online
   
   scheduler starts up the task again... i assume maybe it gets a new queued_by_job_id -- but the pod has the old id?
   
   does the queued by id even matter?  should we not just be looking at things that uniquely identify the TI?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org