You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2024/11/07 15:06:36 UTC

[I] Lead the OTEL cleanup project [airflow]

dstandish opened a new issue, #43789:
URL: https://github.com/apache/airflow/issues/43789

   ### Body
   
   OTEL code has increased obfuscation in the airflow codebase.
   
   It's made it harder to follow non-OTEL code (maybe call it "operative" code).  And the volume of it also made it harder to evaluate the OTEL code.
   
   There are two high level things we need to do.
   
   1. we need to reduce the obfuscation from the OTEL code.  That is, reduce the OTEL-related noise in the scheduler and all other areas of airflow code where it is used.  Here's one small example of how the situation can be improved: https://github.com/apache/airflow/pull/43787
   
   2. We need to do a thorough review of all the OTEL code to identify and root out bad behavior.
    
   The first part of this should help with the second.  And progress on 2 can be made while working on 1.
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Lead the OTEL cleanup project [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on issue #43789:
URL: https://github.com/apache/airflow/issues/43789#issuecomment-2794729783

   aah cool, go for it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Lead the OTEL cleanup project [airflow]

Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on issue #43789:
URL: https://github.com/apache/airflow/issues/43789#issuecomment-2794699495

   Hi @kaxil, I'm working on a follow-up PR for #43941 that will also do some general cleanup on the codebase, which seems related to this issue. The patch is almost ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Lead the OTEL cleanup project [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on issue #43789:
URL: https://github.com/apache/airflow/issues/43789#issuecomment-2475010604

   small PR: https://github.com/apache/airflow/pull/43982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Lead the OTEL cleanup project [airflow]

Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on issue #43789:
URL: https://github.com/apache/airflow/issues/43789#issuecomment-2539337002

   Hello, I just came across this issue. I have an open PR for changing the Otel implementation.
   
   https://github.com/apache/airflow/pull/43941
   
   I was also planning to create a follow up patch for cleanup after this one was merged. To avoid contributing to the existing obfuscation, I'll try to extract the otel-related code to new methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Lead the OTEL cleanup project [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed issue #43789: Lead the OTEL cleanup project
URL: https://github.com/apache/airflow/issues/43789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org