You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/11/27 04:17:59 UTC
spark git commit: [SPARK-11778][SQL] add regression test
Repository: spark
Updated Branches:
refs/heads/master d8220885c -> 4d4cbc034
[SPARK-11778][SQL] add regression test
Fix regression test for SPARK-11778.
marmbrus
Could you please take a look?
Thank you very much!!
Author: Huaxin Gao <hu...@oc0558782468.ibm.com>
Closes #9890 from huaxingao/spark-11778-regression-test.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/4d4cbc03
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/4d4cbc03
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/4d4cbc03
Branch: refs/heads/master
Commit: 4d4cbc034bef559f47f8b74cecd8196dc8a85348
Parents: d822088
Author: Huaxin Gao <hu...@oc0558782468.ibm.com>
Authored: Thu Nov 26 19:17:46 2015 -0800
Committer: Reynold Xin <rx...@databricks.com>
Committed: Thu Nov 26 19:17:46 2015 -0800
----------------------------------------------------------------------
.../sql/hive/HiveDataFrameAnalyticsSuite.scala | 10 ------
.../spark/sql/hive/HiveDataFrameSuite.scala | 32 ++++++++++++++++++++
2 files changed, 32 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/4d4cbc03/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
index f19a74d..9864acf 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
@@ -34,14 +34,10 @@ class HiveDataFrameAnalyticsSuite extends QueryTest with TestHiveSingleton with
override def beforeAll() {
testData = Seq((1, 2), (2, 2), (3, 4)).toDF("a", "b")
hiveContext.registerDataFrameAsTable(testData, "mytable")
- hiveContext.sql("create schema usrdb")
- hiveContext.sql("create table usrdb.test(c1 int)")
}
override def afterAll(): Unit = {
hiveContext.dropTempTable("mytable")
- hiveContext.sql("drop table usrdb.test")
- hiveContext.sql("drop schema usrdb")
}
test("rollup") {
@@ -78,10 +74,4 @@ class HiveDataFrameAnalyticsSuite extends QueryTest with TestHiveSingleton with
sql("select a, b, sum(b) from mytable group by a, b with cube").collect()
)
}
-
- // There was a bug in DataFrameFrameReader.table and it has problem for table with schema name,
- // Before fix, it throw Exceptionorg.apache.spark.sql.catalyst.analysis.NoSuchTableException
- test("table name with schema") {
- hiveContext.read.table("usrdb.test")
- }
}
http://git-wip-us.apache.org/repos/asf/spark/blob/4d4cbc03/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
new file mode 100644
index 0000000..7fdc5d7
--- /dev/null
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.apache.spark.sql.hive.test.TestHiveSingleton
+import org.apache.spark.sql.QueryTest
+
+class HiveDataFrameSuite extends QueryTest with TestHiveSingleton {
+ test("table name with schema") {
+ // regression test for SPARK-11778
+ hiveContext.sql("create schema usrdb")
+ hiveContext.sql("create table usrdb.test(c int)")
+ hiveContext.read.table("usrdb.test")
+ hiveContext.sql("drop table usrdb.test")
+ hiveContext.sql("drop schema usrdb")
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org