You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/10 02:13:18 UTC

[GitHub] [skywalking-showcase] kezhenxu94 commented on pull request #110: Bump json5 from 1.0.1 to 1.0.2 in /services/app/frontend

kezhenxu94 commented on PR #110:
URL: https://github.com/apache/skywalking-showcase/pull/110#issuecomment-1376629812

   > > 
   > 
   > 
   > 
   > Yes, it is. BTW, we need to add the `skywalking-client-js` to dependencies in package.json.
   
   We don't need that. We want to be able to install arbitrary version of client js (including unreleased commits), and we do that in https://github.com/apache/skywalking-showcase/blob/main/services/app/frontend/Dockerfile#L25-L36 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org