You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by microwishing <gi...@git.apache.org> on 2015/12/03 06:30:50 UTC
[GitHub] spark pull request: [DOC]fix typo
GitHub user microwishing opened a pull request:
https://github.com/apache/spark/pull/10121
[DOC]fix typo
this is to fix some typo in external/kafka/src/main/scala/org/apache/spark/streaming/kafka/OffsetRange.scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/microwishing/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10121
----
commit 46a049fcdfbba4be3ba499b6c68f8faf2d12a989
Author: microwishing <we...@kaiyuandao.com>
Date: 2015-12-03T02:09:05Z
fix typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161547029
@microwishing can you have a look at the rest of the doc around this for any other typos? even small PRs have nonzero overhead, so I'm encouraging people to not just open a PR for single typos as they see them, but take a little time, if they're bothering, to evaluate similar issues around the change. Maybe there aren't any.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION]fix typo
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161521749
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by microwishing <gi...@git.apache.org>.
Github user microwishing commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161586166
@srowen thanks for your tips. I happened to work on some kafka project recently so I went through source codes including comments for spark kafka streaming part today.
I spent some time setting up the spark dev environment and feel good so far due to rich doc. Those are indeed trivial typos. I can make check-ins next time after fixing some real bugs there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161692696
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161691372
**[Test build #2163 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2163/consoleFull)** for PR 10121 at commit [`97dfb8b`](https://github.com/apache/spark/commit/97dfb8b735318438bf4a9f71151ee4b4f1769a47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOCUMENTATION][KAFKA] fix typo in kafka/Offse...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10121#issuecomment-161679237
**[Test build #2163 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2163/consoleFull)** for PR 10121 at commit [`97dfb8b`](https://github.com/apache/spark/commit/97dfb8b735318438bf4a9f71151ee4b4f1769a47).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org